Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update mexc provider to use v3 api #367

Merged
merged 6 commits into from
Mar 28, 2024
Merged

fix: Update mexc provider to use v3 api #367

merged 6 commits into from
Mar 28, 2024

Conversation

rbajollari
Copy link
Collaborator

Description

closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@rbajollari rbajollari requested a review from a team as a code owner March 28, 2024 15:34
adamewozniak
adamewozniak approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@adamewozniak adamewozniak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just one nit
good to merge once this + lint is in

oracle/provider/mexc.go Outdated Show resolved Hide resolved
@rbajollari rbajollari added the S:backport/umee Backport changes to umee branch label Mar 28, 2024
@rbajollari rbajollari merged commit f10accf into main Mar 28, 2024
15 of 16 checks passed
@rbajollari rbajollari deleted the ryab/mexc-provider-v3 branch March 28, 2024 20:28
mergify bot pushed a commit that referenced this pull request Mar 28, 2024
@rbajollari @mergify
fix: Update mexc provider to use v3 api (#367)
09b7821 
* fix: Update mexc provider to use v3 api

* lint

* pr comments

* args

* err lint

* comment out astroport test

(cherry picked from commit f10accf)

# Conflicts:
#	oracle/provider/astroport_test.go
@mergify mergify bot mentioned this pull request Mar 28, 2024
Merged
17 tasks
rbajollari added a commit that referenced this pull request Mar 28, 2024
@mergify @rbajollari
fix: Update mexc provider to use v3 api (backport #367) (#368)
d0fdb31 
* fix: Update mexc provider to use v3 api (#367)

* fix: Update mexc provider to use v3 api

* lint

* pr comments

* args

* err lint

* comment out astroport test

(cherry picked from commit f10accf)

# Conflicts:
#	oracle/provider/astroport_test.go

* switch order config test

---------

Co-authored-by: ryanbajollari <[email protected]>
Co-authored-by: rbajollari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamewozniak adamewozniak adamewozniak approved these changes

Assignees
No one assigned
Labels
S:backport/umee Backport changes to umee branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbajollari @adamewozniak