Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clientless oracle tick capable of being called by the Ojo oracle module #400

Merged
merged 13 commits into from
Sep 13, 2024

Conversation

rbajollari
Copy link
Collaborator

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@rbajollari rbajollari requested a review from a team as a code owner July 31, 2024 22:41
@rbajollari rbajollari changed the title fix: Make sure oracle param cache is updated in clientless tick fix: Clientless oracle tick capable of being called by the Ojo oracle module Aug 29, 2024
@adamewozniak
Copy link
Member

Can we open an issue with the dependency problem here:

https://github.com/advisories/GHSA-hg58-rf2h-6rr7

Copy link
Member

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

we need to merge this, cut a new RC, and tag the associated ojo binary PR to it so that we're not merging PRs with commit hash dependencies

@rbajollari rbajollari merged commit 5f82e10 into main Sep 13, 2024
14 of 16 checks passed
@rbajollari rbajollari deleted the ryan/clientless-param-cache branch September 13, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants