Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add WSTETH/WETH as supported conversion (backport #410) #411

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 5, 2024

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

This is an automatic backport of pull request #410 done by [Mergify](https://mergify.com).

* feat: Add WSTETH/WETH as supported conversion

* one conversion path deeper

* lint

(cherry picked from commit 8876d36)

# Conflicts:
#	oracle/util.go
@mergify mergify bot requested a review from a team as a code owner September 5, 2024 20:20
@mergify mergify bot added the conflicts label Sep 5, 2024
Copy link
Author

mergify bot commented Sep 5, 2024

Cherry-pick of 8876d36 has failed:

On branch mergify/bp/release/v0.1.x/pr-410
Your branch is up to date with 'origin/release/v0.1.x'.

You are currently cherry-picking commit 8876d36.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   config/supported_assets.go
	modified:   oracle/convert.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   oracle/util.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Sep 5, 2024
17 tasks
@rbajollari rbajollari merged commit 59c2e44 into release/v0.1.x Sep 5, 2024
14 of 16 checks passed
@rbajollari rbajollari deleted the mergify/bp/release/v0.1.x/pr-410 branch September 5, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant