Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in v4.13.0 and v4.13.1 related to resource okta_app_signon_policy #2240

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

monde
Copy link
Collaborator

@monde monde commented Mar 5, 2025

Fixes the update to okta_app_signon_policy resource that failed to set default_rule_id on update and read which would break imports and applies to okta_app_signon_policy instances created before v4.13.0.

Puts bumpers on a nil path that can happen during destroy.

Added acceptance tests to validate catch_all is working as advertised.

catch_all (Boolean, default true, creation-only argument) If false, the default rule of the policy is set access to DENY. Otherwise default behavior of the default rule is to leave access at ALLOW. WARNING setting this attribute to false changes policy rule's default behavior. Use at your own risk. This is only applied during creation and does not affect import or update.

Closes #2197
Closes #2199
Closes #2198

@monde monde merged commit 988b8de into master Mar 5, 2025
3 checks passed
@monde monde deleted the resource_okta_app_signon_policy_fixes branch March 5, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants