-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OMX Version 1.13.1 #62
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of the Arduino IDE settings
…e of the Arduino IDE settings
Keys now play the chords of loaded preset. F1 + Key to load, F2 + Key to save. Chord edit view only available in edit mode. Improved disp messages to help user.
Problem was that if chance kicked in and the notes did not get sent to the arp on a noteon event, then when the noteoff event happend, if it got sent to arp instead of passing through, a note off would not be sent for the note and a single note will get stuck on. The arp could also get stuck, acting like it is in hold mode. To fix this, I tracked notes getting passed through using trackingNoteGroupsPassthrough for up to 8 notes. notes with fixed lengths ignored since they will turn off automatically. By tracking these notes, I pass them through for noteoffs in the case they were previously passed through noteons.
…sabling mode if debug build needed to gain space
…ks in Chords, Keyboard, and Drums now.
Bugfix for CV gates being turned off when playing legato
…startupScreenVersionNumber
Startup screen version number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of bug fixes, improvements, updated documentation.
New Modes:
New MidiFX:
New Macro Mode:
New Passthrough QuickEdit Mode for editing MidiFX and playing keyboard.
Bug Fixes / Improvements:
Code:
Chords Mode:
Arp:
Randomizer: