Screensaver color depth fix - add missing colors to screensaver, plus an 'off' state #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The screensaver was only using half of the rainbow of colors. This fix enables the full range of colors, plus
blackif the potentiometer is turned fully clockwise, allowing the screensaver to effectively be turned off if desired.This pull request includes several changes to the
OMX-27-firmwareproject, focusing on improving the screensaver functionality and fixing a minor issue with potentiometer value ranges. The most important changes include updating the potentiometer maximum values, refining the screensaver color setting logic, and adding a new configuration parameter for color depth.Potentiometer Value Range Fix:
OMX-27-firmware/src/config.cpp: Corrected the maximum potentiometer value for T3.2 from 8190 to 8191. This corrected themapfunction that sets the color according to the potentiometer value.Screensaver Functionality Enhancements:
OMX-27-firmware/src/modes/omx_screensaver.cpp: Modified thesetScreenSaverColormethod to use a newssMaxColorDepthparameter instead of a hardcoded value. [1] [2]OMX-27-firmware/src/modes/omx_screensaver.cpp: Added a check to update the screensaver color only if the relevant potentiometer has changed.OMX-27-firmware/src/modes/omx_screensaver.cpp: Updated theupdateScreenSaverStatemethod to set the screensaver color when the screensaver becomes active.OMX-27-firmware/src/modes/omx_screensaver.h: Introduced a newssMaxColorDepthparameter for better color configuration.