Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export parser types #286

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Export parser types #286

merged 1 commit into from
Oct 13, 2024

Conversation

DaniPopes
Copy link
Contributor

CommentParser is unnameable from outside this crate, meaning a user cannot declare a parser function with fn, only inline with a closure. I've fixed this by exporting parser::*, and enabled the unreachable_pub and unnameable_types to catch this and other unreachable types.

@oli-obk oli-obk merged commit a0ddf64 into oli-obk:main Oct 13, 2024
8 checks passed
@oli-obk
Copy link
Owner

oli-obk commented Oct 13, 2024

Thanks! That lint is so helpful

@DaniPopes DaniPopes deleted the export-parser branch October 13, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants