alembic_utils dependency on alembic op in single migration #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
resolves #41 |
|
@mjpieters would you be able to check out this branch and test if it resolves your use-case / provide usage feedback? |
|
The holdup on this is that if the alembic (non-utils) operations are expensive e.g. adding a new column with a server default to a large existing table, resolving the correct migration op for the alembic_utils entities is extremely expensive. Currently thinking about whitelisting certain alembic ops or altering them before executing to ensure that they all execute quickly, but that is significantly more complicated that this draft |
|
Seen error requires investigation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute required ops from alembic when resolving required ops for alembic_utils ReplaceableEntities