Adding Remote hw_target support in Vivado backend with 'hw_server_url' tool option. #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Completely missed this one. Sorry about that. Patch looks fine, but since you added this we have moved to a new API in Edalize called the Flow API. The changes would need to be in https://github.com/olofk/edalize/blob/main/edalize/tools/vivado.py and https://github.com/olofk/edalize/blob/main/edalize/tools/templates/vivado/vivado-program.tcl.j2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for 'hw_server_url' tool option for Vivado backend, which takes the string (url and port) provided and passes it to the 'connect_hw_server' command in the program.tcl template with the "-url" tag, outputting the following command:
connect_hw_server -url <hw_server_url>if the hw_server_url is provided as a tool option for target.