Add initial and basic VPR support with the new Edalize API #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olofk
reviewed
Feb 3, 2022
| def __init__(self, edam, work_root, verbose=False): | ||
| Edaflow.__init__(self, edam, work_root, verbose) | ||
|
|
||
| def build_tool_graph(self): |
There was a problem hiding this comment.
I believe this function can be dropped since it just calls the parent class
olofk
reviewed
Feb 3, 2022
|
I agree about the XML arch files. Let's go with this for now and we'll solve how to find them programatically later. FYI, I have started a project on this already with the working name pdk-config focusing on symbiflow and openlane to begin with. Added a few comments above, and then there's one more thing that needs to be fixed. Each tool must create a new EDAM struct with its outputs so that the next tool in the chain can pick it up. See here for an example of how nextpnr does this |
added 2 commits
February 4, 2022 11:37
Signed-off-by: Alessandro Comodi <[email protected]>
Signed-off-by: Alessandro Comodi <[email protected]>
acomodi
force-pushed
the
add-vpr-support
branch
from
2af2816 to
908b8a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic support for VPR for the new Edalize API and calls the tool directly, without passing through wrappers.
I believe this is quite similar to #271, and currently it still requires the XML architecture file to be provided by the user. As per the discussion in #271, I believe that in the long term we should enhance VTR to have a pckg-config-like feature, that allows to have a
sharedir from which VTR automatically selects the correct arch, RR graph, and other files required for the build.I think that as a first step we may allow the user to pass the paths to these files, and once VTR will have the
pkg-configfeature, we can fix the VPR support in Edalize accordingly.Signed-off-by: Alessandro Comodi [email protected]