forked from ESCOMP/CTSM
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request ESCOMP#2390 from ESCOMP/hillslope-merge
Bring in hillslope hydrology.
- Loading branch information
Showing
70 changed files
with
3,901 additions
and
973 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,4 +98,4 @@ tag = v1.0.8 | |
required = False | ||
|
||
[externals_description] | ||
schema_version = 1.0.0 | ||
schema_version = 1.0.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
cime_config/testdefs/testmods_dirs/clm/Hillslope/include_user_mods
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../default |
4 changes: 4 additions & 0 deletions
4
cime_config/testdefs/testmods_dirs/clm/Hillslope/shell_commands
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
./xmlchange CLM_BLDNML_OPTS="-bgc sp" | ||
DIN_LOC_ROOT=$(./xmlquery --value DIN_LOC_ROOT) | ||
meshfile=$DIN_LOC_ROOT/lnd/clm2/testdata/ESMFmesh_10x15_synthetic_cosphill_1.0.nc | ||
./xmlchange ATM_DOMAIN_MESH=${meshfile},LND_DOMAIN_MESH=${meshfile} |
11 changes: 11 additions & 0 deletions
11
cime_config/testdefs/testmods_dirs/clm/Hillslope/user_nl_clm
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
use_hillslope = .true. | ||
use_hillslope_routing = .true. | ||
downscale_hillslope_meteorology = .false. | ||
hillslope_head_gradient_method = 'Darcy' | ||
hillslope_transmissivity_method = 'LayerSum' | ||
hillslope_pft_distribution_method = 'PftLowlandUpland' | ||
hillslope_soil_profile_method = 'Uniform' | ||
|
||
fsurdat = '$DIN_LOC_ROOT/lnd/clm2/testdata/surfdata_10x15_78pfts_simyr2000_synthetic_cosphill_1.3.nc' | ||
|
||
use_ssre = .false. |
1 change: 1 addition & 0 deletions
1
cime_config/testdefs/testmods_dirs/clm/HillslopeC/include_user_mods
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../Hillslope |
7 changes: 7 additions & 0 deletions
7
cime_config/testdefs/testmods_dirs/clm/HillslopeC/user_nl_clm
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
! Various hillslope options not exercised by other testmods | ||
use_hillslope_routing = .false. | ||
downscale_hillslope_meteorology = .true. | ||
hillslope_head_gradient_method = 'Kinematic' | ||
hillslope_transmissivity_method = 'Uniform' | ||
hillslope_pft_distribution_method = 'DominantPftUniform' | ||
hillslope_soil_profile_method = 'SetLowlandUpland' |
1 change: 1 addition & 0 deletions
1
cime_config/testdefs/testmods_dirs/clm/HillslopeD/include_user_mods
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../Hillslope |
3 changes: 3 additions & 0 deletions
3
cime_config/testdefs/testmods_dirs/clm/HillslopeD/user_nl_clm
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
! Various hillslope options not exercised by other testmods | ||
hillslope_pft_distribution_method = 'DominantPftLowland' | ||
hillslope_soil_profile_method = 'Linear' |
1 change: 1 addition & 0 deletions
1
cime_config/testdefs/testmods_dirs/clm/HillslopeFromFile/include_user_mods
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../Hillslope |
2 changes: 2 additions & 0 deletions
2
cime_config/testdefs/testmods_dirs/clm/HillslopeFromFile/user_nl_clm
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
hillslope_pft_distribution_method = 'FromFile' | ||
hillslope_soil_profile_method = 'FromFile' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
snow_cover_fraction_method = 'NiuYang2007' | ||
h2osfcflag = 0 | ||
origflag = 1 | ||
use_subgrid_fluxes = .false. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,77 @@ | ||
=============================================================== | ||
Tag name: ctsm5.1.dev170 | ||
Originator(s): samrabin (Sam Rabin, UCAR/TSS, [email protected]) | ||
Date: Wed Feb 28 11:01:43 MST 2024 | ||
One-line Summary: Add hillslope hydrology | ||
|
||
Purpose and description of changes | ||
---------------------------------- | ||
|
||
Changes include multiple soil columns per vegetated landunit, additional meteorological downscaling, new subsurface lateral flow equations, and a hillslope routing parameterization. | ||
|
||
Described in: | ||
Swenson, S. C., Clark, M., Fan, Y., Lawrence, D. M., & Perket, J. (2019). Representing intra-hillslope lateral subsurface flow in the community land model. Journal of Advances in Modeling Earth Systems, 11, 4044–4065. https://doi.org/10.1029/2019MS001833 | ||
|
||
|
||
Significant changes to scientifically-supported configurations | ||
-------------------------------------------------------------- | ||
|
||
Does this tag change answers significantly for any of the following physics configurations? | ||
(Details of any changes will be given in the "Answer changes" section below.) | ||
|
||
[Put an [X] in the box for any configuration with significant answer changes.] | ||
|
||
[ ] clm5_1 | ||
|
||
[ ] clm5_0 | ||
|
||
[ ] ctsm5_0-nwp | ||
|
||
[ ] clm4_5 | ||
|
||
|
||
Notes of particular relevance for developers: | ||
--------------------------------------------- | ||
|
||
Changes to tests or testing: | ||
* oldhyd test changes answers due to removal of origflag parameter | ||
* Adds several hillslope-specific tests | ||
|
||
|
||
Testing summary: | ||
---------------- | ||
|
||
regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing): | ||
|
||
derecho ----- DIFF | ||
izumi ------- DIFF | ||
|
||
|
||
Answer changes | ||
-------------- | ||
|
||
Summarize any changes to answers, i.e., | ||
- what code configurations: all | ||
- what platforms/compilers: all | ||
- nature of change: roundoff | ||
|
||
If bitwise differences were observed, how did you show they were no worse | ||
than roundoff? Roundoff differences means one or more lines of code change results | ||
only by roundoff level (because order of operation changes for example). Roundoff | ||
changes to state fields usually grow to greater than roundoff as the simulation progresses. | ||
* FSDS answers change due to rounding differences, since the history field now uses a column-level variable instead of a gridcell-level one. Note that this is JUST the history field that's affected, which is why there are no diffs in any other variable. (Confirmed using branch at https://github.com/samsrabin/CTSM/tree/hillslope-revert-fsds-diffs.) | ||
* The origflag parameter (used to reproduce CLM4 behavior) was removed, so anything using that will break. This includes the oldhyd test. | ||
|
||
|
||
Other details | ||
------------- | ||
|
||
Pull Requests that document the changes (include PR ids): | ||
* ESCOMP/CTSM#1715: Hillslope hydrology (https://github.com/ESCOMP/CTSM/pull/1715) | ||
* ESCOMP/CTSM#2390: Hillslope merge (https://github.com/ESCOMP/CTSM/pull/2390) | ||
|
||
=============================================================== | ||
=============================================================== | ||
Tag name: ctsm5.1.dev169 | ||
Originator(s): samrabin (Sam Rabin, UCAR/TSS, [email protected]) | ||
Date: Thu 22 Feb 2024 09:42:57 AM MST | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.