matlab/bfGetPlane.m: avoid use of makeDataArray2D when Octave (ome/bio-formats-octave-docker#29) #4130
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-formats-octave-docker#29) Octave does not autobox multi-dimensional arrays (Matlab does) so we can't use makeDataArray2D. Instead, use makeDataArray to get a 1D array and reshape it. This commit partially reverts 3aa468e (see ome#3301) for Octave only, so the data copy is back but for Octave only.
|
Thank you @carandraug for opening the PR and the continued support for the the project. Since your previous contributions we have introduced a Contributor License Agreement for the project, would you be able to sign and return the form following the instructions on https://ome-contributing.readthedocs.io/en/latest/cla.html |
|
I'm not willing to that CLA at the moment. If you prefer, this patch is too trivial and I do not claim copyright for it. |
|
I've reached out separately to David P. to discuss this and his other contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes ome/bio-formats-octave-docker#29
Octave does not autobox multi-dimensional arrays (Matlab does) so
makeDataArray2Dcan't be used in Octave. this commit makes use ofmakeDataArrayto get a 1D array and then reshapes it. This commit partially reverts 3aa468e (see #3301) for Octave only. the data copy that that commit was meant to prevent is back but is limited to Octave.For reference, the issue of Octave not autoboxing ND Java arrays is Octave bug #58745 (the issue description references a function
java2matthat in theory should make this conversion but that function never worked for me and newer Octave functions have marked it somewhat internal by renaming it__java2mat__).