Coordinate systems and new coordinate transformations proposal #138
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "arrayCoordinateSystem" : { | ||
| "name" : "myDataArray", | ||
| "axes" : [ | ||
| {"name": "i", "type": "array"}, | ||
| {"name": "j", "type": "array"}, | ||
| {"name": "k", "type": "array"} | ||
| ] | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| { | ||
| "multiscales": [ | ||
| { | ||
| "version": "0.5-dev", | ||
| "name": "example", | ||
| "coordinateSystems" : [ | ||
| { | ||
| "name" : "exampleCoordinateSystem", | ||
| "axes": [ | ||
| {"name": "t", "type": "time", "unit": "millisecond"}, | ||
| {"name": "c", "type": "channel"}, | ||
| {"name": "z", "type": "space", "unit": "micrometer"}, | ||
| {"name": "y", "type": "space", "unit": "micrometer"}, | ||
| {"name": "x", "type": "space", "unit": "micrometer"} | ||
| ] | ||
| } | ||
| ], | ||
| "datasets": [ | ||
| { | ||
| "path": "0" | ||
| // the transformation of other arrays are defined relative to this, the highest resolution, array | ||
| }, | ||
| { | ||
| "path": "1", | ||
| "coordinateTransformations": [{ | ||
| // the second scale level (downscaled by a factor of 2 relative to "0" in zyx) | ||
| "type": "scale", | ||
| "scale": [1, 1, 2, 2, 2], | ||
| "input" : "/1`", | ||
| "output" : "/0" | ||
| }] | ||
| }, | ||
| { | ||
| "path": "2", | ||
| "coordinateTransformations": [{ | ||
| // the third scale level (downscaled by a factor of 4 relative to "0" in zyx) | ||
| "type": "scale", | ||
| "scale": [1, 1, 4, 4, 4], | ||
| "input" : "/2", | ||
| "output" : "/0" | ||
| }] | ||
| } | ||
| ], | ||
| "coordinateTransformations": [{ | ||
| // the time unit (0.1 milliseconds), the voxel size for all spatial axes of "0" (0.5 micrometers) | ||
| "type": "scale", | ||
| "scale": [0.1, 1.0, 0.5, 0.5, 0.5], | ||
| "input" : "/0", | ||
| "output" : "xampleCoordinateSystem" | ||
|
|
||
| }], | ||
| "type": "gaussian", | ||
| "metadata": { | ||
| "description": "the fields in metadata depend on the downscaling implementation. Here, the parameters passed to the skimage function are given", | ||
| "method": "skimage.transform.pyramid_gaussian", | ||
| "version": "0.16.1", | ||
| "args": "[true]", | ||
| "kwargs": {"multichannel": true} | ||
| } | ||
| } | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| { | ||
| "coordinateSystems" : [ | ||
| { "name " : "in", "axes" : [ {"name" : "0", "name" : "1", "name": "2", "name": "3", "name": "4" }] }, | ||
| { "name " : "out", "axes" : [ {"name" : "x", "name" : "y", "name" : "z" }] } | ||
| ], | ||
| "coordinateTransformations" : [ | ||
| { | ||
| "type" : "sequence", | ||
| "name" : "5D-to-3D", | ||
| "input" : "in", | ||
| "output" : "out", | ||
| "transformations" : [ | ||
| { | ||
| "type": "mapIndex", | ||
| "inputAxes" : ["0", "1"], | ||
| "outputAxes" : ["x", "y"] | ||
| }, | ||
| { | ||
| "type": "scale", | ||
| "scale" : [2], | ||
| "inputAxes" : ["3"], | ||
| "outputAxes" : ["z"] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "type" : "sequence", | ||
| "name" : "5D-to-3D-not-contiguous", | ||
| "input" : "in", | ||
| "output" : "out", | ||
| "transformations" : [ | ||
| { | ||
| "type": "mapIndex", | ||
| "inputAxes" : ["0", "2"], | ||
| "outputAxes" : ["x", "z"] | ||
| }, | ||
| { | ||
| "type": "scale", | ||
| "scale" : [2], | ||
| "inputAxes" : ["1"], | ||
| "outputAxes" : ["y"] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "type" : "sequence", | ||
| "name" : "5D-to-3D-not-contiguous", | ||
| "input" : "in", | ||
| "output" : "out", | ||
| "transformations" : [ | ||
| { | ||
| "type": "mapAxes", | ||
| "map" : {"0":"x", "2":"z"} | ||
| }, | ||
| { | ||
| "type": "scale", | ||
| "scale" : [2], | ||
| "inputAxes" : ["1"], | ||
| "outputAxes" : ["y"] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "coordinateSystems" : [ | ||
| { "name " : "in", "axes" : [ {"name" : "i", "name" : "j" }] }, | ||
| { "name " : "out", "axes" : [ {"name" : "x", "name" : "y" }] } | ||
|
There was a problem hiding this comment. axes are both single-item lists containing a dict with multiple |
||
| ], | ||
| "coordinateTransformations" : [ | ||
| { | ||
| "type" : "sequence", | ||
| "input" : "in", | ||
| "output" : "out", | ||
| "transformations" : [ | ||
| { | ||
| "type": "identity", | ||
| "inputAxes" : ["j"], | ||
| "outputAxes" : ["x"] | ||
| }, | ||
| { | ||
| "type": "scale", | ||
| "scale" : [2], | ||
| "inputAxes" : ["i"], | ||
| "outputAxes" : ["y"] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "coordinateSystems" : [ | ||
| { "name": "ij", "axes": [{"name": "i"}, {"name": "j"}] }, | ||
| { "name": "xy", "axes": [{"name": "x"}, {"name": "y"}] } | ||
| ], | ||
| "coordinateTransformations" : [ | ||
| { | ||
| "type": "affine", | ||
| "affine": [1, 2, 3, 4, 5, 6], | ||
| "input": "ij", | ||
| "output": "xy" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "coordinateSystems": [ | ||
| { "name": "ij", "axes": [{"name": "i"}, {"name": "j"}] }, | ||
| { "name": "xyz", "axes": [{"name": "x"}, {"name": "y"}, {"name": "z"}] } | ||
| ], | ||
| "coordinateTransformations": [ | ||
| { | ||
| "type": "affine", | ||
| "affine": [1, 2, 3, 4, 5, 6, 7, 8, 9], | ||
| "input": "ij", | ||
| "output": "xyz" | ||
| } | ||
| ] | ||
| } | ||
|
There was a problem hiding this comment. This is the first example where I really don't know at first glance what's going on...? There was a problem hiding this comment. Related: #146 (comment) (please @bogovicj close the issue if the nested representation is adopted) |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "coordinateSystems": [ | ||
| { "name": "in", "axes": [ {"name": "i"}, {"name": "j"} ] }, | ||
| { "name": "out", "axes": [ {"name": "x"}, {"name": "y"} ] } | ||
| ], | ||
| "coordinateTransformations": [ | ||
| { | ||
| "type": "byDimension", | ||
| "input": "in", | ||
| "output": "out", | ||
| "transformations": [ | ||
| { "type": "translation", "translation": [-1.0], "input": ["i"], "output": ["x"]}, | ||
| { "type": "scale", "scale": [2.0], "input": ["j"], "output": ["y"]} | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "coordinateSystems": [ | ||
| { "name": "in", "axes": [ {"name": "i"}, {"name": "j"}, {"name": "k"}, {"name": "l"}] }, | ||
| { "name": "out", "axes": [ {"name": "x"}, {"name": "y"}, {"name": "z"} ] } | ||
| ], | ||
| "coordinateTransformations": [ | ||
| { | ||
| "type": "byDimension", | ||
| "input": "in", | ||
| "output": "out", | ||
| "transformations" : [ | ||
| { "type": "translation", "translation": [1, 3], "input": ["i", "k" ], "output": ["y", "x"]}, | ||
| { "type": "scale", "scale": [2.0], "input": ["j"], "output": ["z"]} | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "coordinateSystems": [ | ||
| { "name": "in", "axes": [ {"name": "i"}, {"name": "j"} ] }, | ||
| { "name": "out", "axes": [ {"name": "x"}, {"name": "y"} ] } | ||
| ], | ||
| "coordinateTransformations": [ | ||
| { | ||
| "type": "byDimension", | ||
| "input": "in", | ||
| "output": "out", | ||
| "transformations": [ | ||
| { "type": "translation", "translation": [-1.0], "input": ["i"], "output": ["z"]}, | ||
| { "type": "scale", "scale": [2.0], "input": ["0"], "output": ["y"]} | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "coordinateSystems": [ | ||
| { "name": "in", "axes": [ {"name": "i"}, {"name": "j"} ] }, | ||
| { "name": "out", "axes": [ {"name": "x"}, {"name": "y"} ] } | ||
| ], | ||
| "coordinateTransformations": [ | ||
| { | ||
| "type": "byDimension", | ||
| "input": "in", | ||
| "output": "out", | ||
| "transformations": [ | ||
| { "type": "translation", "translation": [-1.0], "input": ["i"], "output": ["x"]}, | ||
| { "type": "scale", "scale": [2.0], "input": ["i"], "output": ["x"]} | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "coordinateSystems": [ | ||
| { "name": "i", "axes": [{"name": "i"}] }, | ||
| { "name": "x", "axes": [{"name": "x"}] } | ||
| ], | ||
| "coordinateTransformations": [{ | ||
| "name": "a coordinate field transform", | ||
| "type": "coordinates", | ||
| "path": "i2xCoordinates", | ||
| "input": "i", | ||
| "output": "x", | ||
| "interpolation": "nearest" | ||
| }] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "coordinateSystems": [ | ||
| { "name": "i", "axes": [{"name": "i"}] }, | ||
| { "name": "x", "axes": [{"name": "x"}] } | ||
| ], | ||
| "coordinateTransformations": [{ | ||
| "name": "a displacement field transform", | ||
| "type": "displacements", | ||
| "path": "i2xCoordinates", | ||
| "input": "i", | ||
| "output": "x", | ||
| "interpolation": "nearest" | ||
| }] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "coordinateSystems": [ | ||
| { "name": "in", "axes": [ {"name": "i"}, {"name": "j"} ]}, | ||
| { "name": "out", "axes": [ {"name": "x"}, {"name": "y"} ]} | ||
| ], | ||
| "coordinateTransformations": [ | ||
| { "type": "identity", "input": "in", "output": "out" } | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to integrate the proposal from #114 which is orthognal to this proposal but is scheduled for discussion at the upcoming OME-NGFF call, how would this be modified?
Would the input still point at the relative path to the resolution group or should it point at the relative path to the resolution array i.e. `"/0/image"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A secondary concern is whether this nomenclature is redundant with the
multiscales.datasets.pathmetadata which also defines the path to the array?