-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toc #19
Toc #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow this is quite a big styling upgrade (using RTD default theme) in addition to a content reorganization - which might address the concerns raised in #16 (comment)
Immediate piece of feedback from my side is that I am not a fan of the intermediate pages like https://ome-contributing--19.org.readthedocs.build/en/19/components-development.html if the only content is a blurb followed by a list of sub-sections. In the top-level page, it also creates an unnecessary nested layer
Unless these section overview pages are deemed to grow, is there any reason not to include the toctree directly under the top-level index.rst
?
Few points from my side but nothing that necessarily must be handled in this PR:
Oops. Now I see I was too slow. Holding off on any proposals until the dust clears. |
@joshmoore Switching to QA so I will not do anything more for now |
Slightly unfortunate that the headings are not also exposed in the left-hand navigation panel (as in https://bio-formats.readthedocs.io/en/latest/users/index.html# for instance). I suspect this comes to the fact they are in the top-level |
@sbesson This is exactly the problem. Either we have intermediate page that show on the left and index or we have the current flat structure |
Fair enough. I think the testing scenarios is a good example of why we might need intermediate pages in the end as the top-level toc tree might become a long flat list of sections otherwise. As mentioned in #19 (comment), the biggest question is whether we are happy with the proposed structure:
|
I have created 3 parts
The main point is to have the correct links into the intermediate pages so we can add new contribution Text can be added and improved later on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least, I feel comfortable with the division of this documentation into the three sections as proposed in the latest commits.
I think it would be great to get this restructuring reviewed and integrated in some form so that we can work on amending/inserting content.
@joshmoore are you comfortable with the proposed split? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. Seconding, @sbesson, this seems like a big improvement. Thanks!
Re-organise the doc in sections