Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V05 dev2 #36

Merged
merged 44 commits into from
Oct 28, 2024
Merged

V05 dev2 #36

merged 44 commits into from
Oct 28, 2024

Conversation

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for ome-ngff-validator ready!

Name Link
🔨 Latest commit 74f4e6f
🔍 Latest deploy log https://app.netlify.com/sites/ome-ngff-validator/deploys/671f972ff1aceb000800ff79
😎 Deploy Preview https://deploy-preview-36--ome-ngff-validator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joshmoore
Copy link
Member

@will-moore @manzt: I've also hard-coded the URL for hms-dbmi/vizarr#172 here as well 👍

@joshmoore
Copy link
Member

When using ome_zarr view idr0001-2551.zarr

image

When using .../idr0001-2551.zarr $ http-server --cors

image

@joshmoore
Copy link
Member

👍 from my side on the additional column:

image

@will-moore
Copy link
Member Author

@joshmoore Not exactly sure what you're doing there....

$ ls plates/
2783928.zarr	4403.zarr	51.zarr
$ http-server --cors

https://deploy-preview-36--ome-ngff-validator.netlify.app/?source=http://127.0.0.1:8080/plates/4403.zarr
Looks good.

Also e.g.

$ $ http-server plates --cors

Works at https://deploy-preview-36--ome-ngff-validator.netlify.app/?source=http://127.0.0.1:8080/4403.zarr
etc.

@joshmoore
Copy link
Member

Sorry, I just wanted to get a screenshot in place. No complaints 😄

@will-moore
Copy link
Member Author

Last commit handles series metadata as in https://deploy-preview-36--ome-ngff-validator.netlify.app/?source=https://radosgw.public.os.wwu.de/n4bi-goe/Platynereis-H2B-TL.ome.zarr/

src/JsonBrowser/DetailsPrePanel.svelte Outdated Show resolved Hide resolved
src/JsonValidator/RoCrate/RoCrateValidator.svelte Outdated Show resolved Hide resolved

async function lookupOrganism(taxonId) {
// taxonId e.g. 9606
const orgJson = await getJson(`https://rest.ensembl.org/taxonomy/id/${taxonId}?content-type=application/json`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url should probably declare in a config file. Not a blocker

src/JsonValidator/RoCrate/index.svelte Outdated Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
src/utils.js Show resolved Hide resolved
public/ngff_viewers.json Outdated Show resolved Hide resolved
src/Bioformats2rawLayout/index.svelte Outdated Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
@will-moore
Copy link
Member Author

Checked with a bunch of various samples from https://idr.github.io/ome-ngff-samples/ - All looking good.
@jburel OK to go ahead and merge?

@will-moore
Copy link
Member Author

Fix pushed. Build is green. Merging...

@will-moore will-moore merged commit d0eab86 into ome:main Oct 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants