-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V05 dev2 #36
V05 dev2 #36
Conversation
✅ Deploy Preview for ome-ngff-validator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@will-moore @manzt: I've also hard-coded the URL for hms-dbmi/vizarr#172 here as well 👍 |
vizarr PR is now merged This reverts commit 3a1ecfb.
@joshmoore Not exactly sure what you're doing there....
https://deploy-preview-36--ome-ngff-validator.netlify.app/?source=http://127.0.0.1:8080/plates/4403.zarr Also e.g.
Works at https://deploy-preview-36--ome-ngff-validator.netlify.app/?source=http://127.0.0.1:8080/4403.zarr |
Sorry, I just wanted to get a screenshot in place. No complaints 😄 |
Last commit handles series metadata as in https://deploy-preview-36--ome-ngff-validator.netlify.app/?source=https://radosgw.public.os.wwu.de/n4bi-goe/Platynereis-H2B-TL.ome.zarr/ |
src/JsonValidator/MultiscaleArrays/ZarrArray/ChunkLoader.svelte
Outdated
Show resolved
Hide resolved
src/JsonValidator/MultiscaleArrays/ZarrArray/ChunkLoader.svelte
Outdated
Show resolved
Hide resolved
src/JsonValidator/MultiscaleArrays/ZarrArray/ChunkViewer.svelte
Outdated
Show resolved
Hide resolved
|
||
async function lookupOrganism(taxonId) { | ||
// taxonId e.g. 9606 | ||
const orgJson = await getJson(`https://rest.ensembl.org/taxonomy/id/${taxonId}?content-type=application/json`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url should probably declare in a config file. Not a blocker
src/JsonValidator/MultiscaleArrays/ZarrArray/ChunkLoader.svelte
Outdated
Show resolved
Hide resolved
src/JsonValidator/MultiscaleArrays/ZarrArray/ChunkLoader.svelte
Outdated
Show resolved
Hide resolved
Checked with a bunch of various samples from https://idr.github.io/ome-ngff-samples/ - All looking good. |
Fix pushed. Build is green. Merging... |
This updates the validator to support
v0.5-dev2
data, as specified at ome/ngff#242.Validating against
image
schema at https://raw.githubusercontent.com/normanrz/ngff/spec-rfc2/latest/schemas/image.schema and also loadingversion
schema from https://raw.githubusercontent.com/normanrz/ngff/spec-rfc2/latest/schemas/version.schemaPreview build viewing sample data:
https://deploy-preview-36--ome-ngff-validator.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/idr/share/ome2024-ngff-challenge/idr0044/4007801.zarr
cc @normanrz
TODO: