For discussion: Use pinned versions for all direct OMERO deps #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manics
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion today in slack with @pwalczysko over how to specify the omero-py version for OMERO.server. In the IDR we use a hidden variable in the omero-server Ansible role to pin the version of
omero-py. @pwalczysko wants to do the same for the outreach servers, which is a good indication that we should come up with a proper solution instead of something that only we know about internally.We could just make the hidden Ansible role variable public. The downside is it's not extensible, since we may want to pin the versions of other dependencies. We may decide it's good enough anyway in which case this PR isn't needed.
This PR changes omero-cli-server to pin omero-py and all direct dependencies.
requirements-*.txtfiles are used so hopefully dependabot can be used to let us know when there are updates, though we still need to test them since this is intended for production servers and will eventually be used in the OMERO.server ansible role. An advantage of pinning everything here is all our servers can use these versions, otherwise each playbook will have to define them.To keep things understandable we should probably version this to match the OMERO.server major version to match other components (i.e.
5.*clients work with5.6.*servers,6.*clients will work with6.*servers, it probably makes sense to do the same for closely coupled server dependencies). Another option is to exactly match the OMERO.server version, so OMERO.server 5.6.3 is recommended to useomero-server==5.6.3, which is perhaps the clearest option, though we'd need to consider the versioning when e.g. bumping a dependency due to a security release.Related to ome/design#103