Inset bugfixes

[will-moore]

Fixes #601
PR contains 2 bug-fixes and 1 minor tweak (improvement)?

Test bug-fix 1:

• Select a panel and use the "Inset" button to create an Inset
• Copy and paste the newly created Inset panel to duplicate it
• Now delete ONE of the 2 inset panels. The inset ROI shouldn't be deleted.
• If you delete the other inset panel the inset ROI should be deleted as before.

Test bug-fix 2:

• Select a panel and use the "Inset" button to create an Inset
• Select both the original panel and the new inset panel.
• Copy and Paste to duplicate the pair of panels
• Repeat the copy and paste to duplicate the 2 panels again.
• Check that each inset ROI is only "linked" to it's corresponding inset panel (that was duplicated at the same time).

Minor change:

• I've made the default panel border to be Yellow (instead of White) and 5px think (instead of 2). This change (particularly the colour) is to avoid possible confusion when a user click on the "Show Border" button and sees no change because the default white border is not visible against the white figure background. Also I found that I prefer 5px thick as it improves visibility of the border and is a better default value?

[will-moore]

@Rdornier I wonder if you could have a look at these 2 bug fixes and 1 possible improvement? (see details above). Thanks!

I think that once this and #592 is merged, we should get the release out since we have a good amount of new stuff now (see changelog at #602).
I'll have a look at your ROI labels ASAP, and can do another release with that when it's ready. Thx

[Rdornier]

@will-moore Sure !

• Bug 1 : OK
• Improvement : OK
• Bug 2 : OK to some extend. If I do copy > paste and then copy > paste, then it is working properly. But If do copy > paste > paste, then the ROIs of the two copied panels are linked together to the last copied ROIs (gray lines). If I move the central panel, nothing append on the central ROI

I think that once this and #592 is merged, we should get the release out since we have a good amount of new stuff now (see changelog at #602).

Yes, I think it is good idea

I'll have a look at your ROI labels ASAP, and can do another release with that when it's ready

Sounds good 👍

[will-moore]

@Rdornier Thanks for catching that! Strange behaviour due to the clipboard data being a shallow copy for new panels. I think it's fixed with that commit above.

[Rdornier]

Yes, it's fixed. 👍