Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perceptibly uniform luts for OMERO.insight #443

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Tom-TBT
Copy link

@Tom-TBT Tom-TBT commented Jul 19, 2024

This PR adds the preview of LUTs introduced in ome/openmicroscopy#6398 to OMERO.insight

@jburel
Copy link
Member

jburel commented Nov 1, 2024

@dominikl The call is done in the web gateway so nothing more to do in insight

@Tom-TBT
Copy link
Author

Tom-TBT commented Nov 4, 2024

I am closing this PR. If the dynamic LUT preview is implemented in OMERO.insight, it would be done differently than this.

@Tom-TBT Tom-TBT closed this Nov 4, 2024
@dominikl
Copy link
Member

dominikl commented Nov 4, 2024

No, I think this PR is correct @Tom-TBT ! Maybe misunderstood @jburel 's comment (that was rather meant for me).

@Tom-TBT Tom-TBT reopened this Nov 4, 2024
@Tom-TBT
Copy link
Author

Tom-TBT commented Nov 4, 2024

Sorry I maybe went a bit too fast.

This PR adds new LUTs to the static png file. If the LUTs I added with ome/openmicroscopy#6398 are also included, then this PR still makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants