Roi encoder allows Shape None #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to have some shapes unloaded. Otherwise ALL shapes must be loaded which may be very large numbers and not efficient
|
Is there a way to construct a unit test for this scenario i.e. a ROI with unloaded (?) shapes? |
will-moore
force-pushed
the
roi_encoder_allows_shape_None
branch
from
aa96c3b
to
1cbe0be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ome/omero-iviewer#335 (comment)
This allows us to have some shapes unloaded. Otherwise ALL shapes must be loaded
which may be very large numbers and not efficient