Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 5.19.6 release #442

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Jan 7, 2025

In preparation of the patch release

@sbesson sbesson requested review from will-moore and jburel January 7, 2025 08:50
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: jean-marie burel <[email protected]>
@sbesson sbesson requested a review from jburel January 7, 2025 21:36
@snoopycrimecop
Copy link
Member

Empty PR description. Please add a short summary of the PR scope and some testing instructions.

@sbesson
Copy link
Member Author

sbesson commented Jan 9, 2025

@will-moore @jburel any other comments or should I go ahead and release this?

Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

It might be nice to acknowledge contributors in the changelog, but I see we haven't been doing it earlier in this file so it's not a blocker.

@sbesson
Copy link
Member Author

sbesson commented Jan 9, 2025

It might be nice to acknowledge contributors in the changelog, but I see we haven't been doing it earlier in this file so it's not a blocker.

Actually we do have precedents in the changelog file. Implemented in af12b7c

@will-moore
Copy link
Member

👍 Great, thx

@sbesson sbesson merged commit 4601855 into ome:master Jan 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants