chore: update gha in main #374

gatici · 2024-12-19T13:40:05Z

Trigger main workflow on:
- Pull requests targeting the main branch.
- Push operations to the main branch or to any tags that match the pattern v.
Run staticcheck, linting, license-check, fossa scan and unit tests
If unit-tests, lint, and staticcheck jobs passes, runs E2E tests.
E2E tests, builds and pushes a Docker image for testing in a dummy repository, thenexecutes tests, and cleans up the Docker image afterward.
Important: We used a dummy docker repository here because a pull request can not access project secrets before merge.
Now, docker token is exposed which shouldn't. We need to find to a way to handle it in better way.
if E2E tests passes, based on changes in the VERSION file, new releases are tagged.
A new Docker image is pushed for tagged releases to the specified Docker registry (docker.io).
Automatically increments the version after a change and creates a pull request to update the VERSION file.

gatici · 2024-12-19T17:04:15Z

Failing with this error.

sudo /var/lib/rancher/rke2/bin/kubectl --kubeconfig /etc/rancher/rke2/rke2.yaml wait deployment -n kube-system --for=condition=available --all --timeout=300s
error: no matching resources found
make[1]: *** [Makefile:261: /home/runner/aether-in-a-box//build/milestones/k8s-ready] Error 1
make[1]: Leaving directory '/home/runner/aether-in-a-box'
make: *** [Makefile:117: run-aiab] Error 2
Error: Process completed with exit code

gab-arrobo · 2024-12-19T19:16:47Z

.github/workflows/main.yml

@@ -109,6 +109,12 @@ jobs:
        run: |
          make docker-build
          make docker-push
+      - name: Create K8s cluster


@gatici,
FYI, I think you can use this GHA: https://github.com/marketplace/actions/kind-cluster instead

gab-arrobo · 2024-12-20T08:03:31Z

Please check whether the issue with the CRDs (e2e GHA) is due to the registries I removed in this commit: gab-arrobo/aether-in-a-box@22a1595

ghislainbourgeois

Shouldn't this use the shared workflow files? For testing, I think we can target the branch directly.

gatici · 2024-12-20T16:20:48Z

Shouldn't this use the shared workflow files? For testing, I think we can target the branch directly.

This PR is only for testing and never will be merged.

gab-arrobo · 2024-12-26T03:54:28Z

@gatici @ghislainbourgeois, I think we can avoid using the DockerHub credentials by using a local registry with the help of this GitHub Action (https://docs.docker.com/build/ci/github-actions/local-registry/). What do you think? The only thing is that I am pretty certain current Helm Charts do not support different registry per NF's image. That is, all images should come from the same registry. However, this is something we can properly address in the Sdcore Hel Charts

gatici · 2025-01-07T14:15:00Z

@gatici @ghislainbourgeois, I think we can avoid using the DockerHub credentials by using a local registry with the help of this GitHub Action (https://docs.docker.com/build/ci/github-actions/local-registry/). What do you think? The only thing is that I am pretty certain current Helm Charts do not support different registry per NF's image. That is, all images should come from the same registry. However, this is something we can properly address in the Sdcore Hel Charts

Hello @gab-arrobo ,
I updated E2E tests section to use charmed-kubernetes using relevant Github action. Helm chart is deployed successfully. At the moment, UPF pod stuck in init status. Other pods become active.
I guess the following line is the reason of the problem.
https://github.com/omec-project/sdcore-helm-charts/blob/4bf08f220245f3d8384126a96b5c2ccec4f8003b/bess-upf/templates/statefulset-upf.yaml#L101
5:03
Where is the PCIDEVICE_INTEL_COM_INTEL_SRIOV_DPDK variable defined ? Could you please help on this ?
I sent you the UPF pod details through Slack.
Many thanks!

gab-arrobo · 2025-01-13T21:36:12Z

@gatici,
From the e2e-test log, there is an error loading the sdcore-5g-values.yaml because of this Condition path '5g-ran-sim.enable' for chart 5g-ran-sim returned non-bool value, the value should be either true or false, but since the file is not properly passed, the variable enable: ${ENABLE_GNBSIM} (https://github.com/gab-arrobo/aether-in-a-box/blob/master/sd-core-5g-values.yaml#L361) is not getting overwritten. Therefore, it looks like the other values are not being overwritten, either. So, the default deployment mode for the UPF is DPDK and that might be the reason why your UPF pod get stuck in initialization state.

WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /home/runner/.kube/config
WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /home/runner/.kube/config
Release "sd-core" does not exist. Installing it now.
dependencies.go:63: Warning: Condition path '5g-ran-sim.enable' for chart 5g-ran-sim returned non-bool value
coalesce.go:237: warning: skipped value for kafka.config: Not a table.
Error: context deadline exceeded
make[1]: *** [Makefile:344: /home/runner/aether-in-a-box//build/milestones/5g-core] Error 1
make[1]: Leaving directory '/home/runner/aether-in-a-box'
make: *** [Makefile:118: run-aiab] Error 2
Error: Process completed with exit code 2.

gatici · 2025-01-14T10:46:52Z

@gatici, From the e2e-test log, there is an error loading the sdcore-5g-values.yaml because of this Condition path '5g-ran-sim.enable' for chart 5g-ran-sim returned non-bool value, the value should be either true or false, but since the file is not properly passed, the variable enable: ${ENABLE_GNBSIM} (https://github.com/gab-arrobo/aether-in-a-box/blob/master/sd-core-5g-values.yaml#L361) is not getting overwritten. Therefore, it looks like the other values are not being overwritten, either. So, the default deployment mode for the UPF is DPDK and that might be the reason why your UPF pod get stuck in initialization state.
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /home/runner/.kube/config
WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /home/runner/.kube/config
Release "sd-core" does not exist. Installing it now.
dependencies.go:63: Warning: Condition path '5g-ran-sim.enable' for chart 5g-ran-sim returned non-bool value
coalesce.go:237: warning: skipped value for kafka.config: Not a table.
Error: context deadline exceeded
make[1]: *** [Makefile:344: /home/runner/aether-in-a-box//build/milestones/5g-core] Error 1
make[1]: Leaving directory '/home/runner/aether-in-a-box'
make: *** [Makefile:118: run-aiab] Error 2
Error: Process completed with exit code 2.

Hello Gabriel,
ENABLE_GNBSIM is set to true while we are running helm command. It should not create a problem.
This error happened once ( strange) but it does not appear again.
gnbsim and UPF pod does not become available.
And I am suspicious about Multus.

gatici@gaticipc:~/omec/gatici/sdcore-helm-charts$ kubectl get pod -n omec2
NAME                           READY   STATUS     RESTARTS   AGE
amf-7645cd8d75-hb482           1/1     Running    0          36m
ausf-764c8b5bc4-tcldh          1/1     Running    0          36m
gnbsim-0                       0/1     Init:0/1   0          36m
init-net-v7qxk                 1/1     Running    0          36m
kafka-0                        1/1     Running    0          36m
metricfunc-6c4885b477-ftgcm    1/1     Running    0          36m
mongodb-0                      1/1     Running    0          36m
mongodb-1                      1/1     Running    0          36m
mongodb-arbiter-0              1/1     Running    0          36m
nrf-5cbc95d9fb-9nknj           1/1     Running    0          36m
nssf-6bc6d746c-gtbrq           1/1     Running    0          36m
pcf-5856f96854-8h46l           1/1     Running    0          36m
sd-core-zookeeper-0            1/1     Running    0          36m
simapp-6887895b44-v6zbz        1/1     Running    0          36m
smf-758c87c9bf-j4h9v           1/1     Running    0          36m
udm-7dd7698685-mcrzx           1/1     Running    0          36m
udr-6d7666db5c-j5ck7           1/1     Running    0          36m
upf-0                          0/5     Init:0/1   0          36m
upf-adapter-54fc984c8f-brpwm   1/1     Running    0          36m
webui-6457c55d55-s8b5c         1/1     Running    0          36m

Here are the latest results.

gatici@gaticipc:~/omec/gabarabo/aether-in-a-box$ make 5g-test
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /home/gatici/.kube/config
WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /home/gatici/.kube/config
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "flannel" chart repository
...Successfully got an update from the "atomix" chart repository
...Successfully got an update from the "rancher" chart repository
...Successfully got an update from the "incubator" chart repository
...Successfully got an update from the "onosproject" chart repository
...Successfully got an update from the "cord" chart repository
...Successfully got an update from the "aether" chart repository
Update Complete. ⎈Happy Helming!⎈
NODE_IP=192.168.1.117 DATA_IFACE=data RAN_SUBNET=192.168.251.0/24 ENABLE_GNBSIM=true envsubst < /home/gatici/omec/gabarabo/aether-in-a-box//sd-core-5g-values.yaml | \
helm upgrade --create-namespace --install --wait  \
        --namespace omec2 \
        --values - \
        sd-core \
        aether/sd-core --version 2.1.0
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /home/gatici/.kube/config
WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /home/gatici/.kube/config
Release "sd-core" does not exist. Installing it now.
coalesce.go:175: warning: skipped value for kafka.config: Not a table.
Error: client rate limiter Wait returned an error: rate: Wait(n=1) would exceed context deadline
make: *** [Makefile:344: /home/gatici/omec/gabarabo/aether-in-a-box//build/milestones/5g-core] Error 1

Signed-off-by: gatici <[email protected]>

gab-arrobo · 2025-01-10T19:06:01Z

.github/workflows/main.yml

-# Copyright 2023 Canonical Ltd.
+# Copyright 2024 Canonical Ltd.


Why do you change this? You can leave it as 2023-present

gab-arrobo · 2025-01-10T19:06:55Z

.github/workflows/main.yml

@@ -63,16 +42,15 @@ jobs:
          args: -v --config ./.golangci.yml

  hadolint:
-    name: hadolint
+    name: Dockerfile linter


I would delete the name

Suggested change

name: Dockerfile linter

gab-arrobo · 2025-01-10T19:09:22Z

.github/workflows/main.yml

+          sudo microk8s addons repo add community https://github.com/canonical/microk8s-community-addons --reference feat/strict-fix-multus
+          sudo microk8s enable multus
+          sudo microk8s kubectl -n kube-system rollout status daemonset/kube-multus-ds
+          sudo microk8s kubectl auth can-i create network-attachment-definitions


As far I know and tested, you do not need sudo in GitHub runners

Suggested change

sudo microk8s addons repo add community https://github.com/canonical/microk8s-community-addons --reference feat/strict-fix-multus

sudo microk8s enable multus

sudo microk8s kubectl -n kube-system rollout status daemonset/kube-multus-ds

sudo microk8s kubectl auth can-i create network-attachment-definitions

microk8s addons repo add community https://github.com/canonical/microk8s-community-addons --reference feat/strict-fix-multus

microk8s enable multus

microk8s kubectl -n kube-system rollout status daemonset/kube-multus-ds

microk8s kubectl auth can-i create network-attachment-definitions

gab-arrobo · 2025-01-10T19:09:40Z

.github/workflows/main.yml

+
+      - name: Export kubeconfig file
+        run: |
+          sudo microk8s kubectl config view --raw > $HOME/.kube/config


Same as previous comment

Suggested change

sudo microk8s kubectl config view --raw > $HOME/.kube/config

microk8s kubectl config view --raw > $HOME/.kube/config

gab-arrobo · 2025-01-15T18:43:26Z

Makefile

+	cd $(HOME) && \
+	git clone https://github.com/gab-arrobo/aether-in-a-box && \
+	cd aether-in-a-box && \
+	yq -i '.5g-control-plane.images |= {"amf": "localhost:32000/5gc-amf:amf-testing"}' sd-core-5g-values.yaml && \


Suggested change

yq -i '.5g-control-plane.images |= {"amf": "localhost:32000/5gc-amf:amf-testing"}' sd-core-5g-values.yaml && \

yq -i '.5g-control-plane.images.tags |= {"amf": "localhost:32000/5gc-amf:amf-testing"}' sd-core-5g-values.yaml && \

gab-arrobo reviewed Dec 19, 2024

View reviewed changes

ghislainbourgeois reviewed Dec 20, 2024

View reviewed changes

gatici marked this pull request as draft December 20, 2024 16:20

gatici added 20 commits January 14, 2025 13:54

update gha to test changes

bbb458b

Signed-off-by: gatici <[email protected]>

remove push.yaml as main.yml covers it

d68dd7e

Signed-off-by: gatici <[email protected]>

fix: add an empty file at the end of Make file

4243f8b

Signed-off-by: gatici <[email protected]>

use an existing secret

2e06892

Signed-off-by: gatici <[email protected]>

fix: image repository and credentials

56f96ca

Signed-off-by: gatici <[email protected]>

chore: change image repository

275116b

Signed-off-by: gatici <[email protected]>

chore: name changes and remove empty lines

66bd618

Signed-off-by: gatici <[email protected]>

chore: use Dockerhub token instead of user

96d2642

Signed-off-by: gatici <[email protected]>

chore: use a dummy docker account to push images

248ed6d

Signed-off-by: gatici <[email protected]>

chore: update aether-in-a-box repository

fa3c769

Signed-off-by: gatici <[email protected]>

chore: fix image name

dbc612a

Signed-off-by: gatici <[email protected]>

update run-aiab step

f2d4ff8

Signed-off-by: gatici <[email protected]>

chore: add k8s cluster addition

9e819ea

Signed-off-by: gatici <[email protected]>

fix: image tag and job version

1b0679c

Signed-off-by: gatici <[email protected]>

chore: set k8s context

d52845d

Signed-off-by: gatici <[email protected]>

fix: use action to create pul request

bd90ac3

Signed-off-by: gatici <[email protected]>

chore: change job name

2bcf86f

Signed-off-by: gatici <[email protected]>

chore: trigger CI

7fd28df

Signed-off-by: gatici <[email protected]>

test: change the order of cert-manager installation in aether-in-box

96c48cf

Signed-off-by: gatici <[email protected]>

chore: trigger

7d2be18

Signed-off-by: gatici <[email protected]>

gatici added 13 commits January 14, 2025 13:55

chore: trigger

fb6df0b

Signed-off-by: gatici <[email protected]>

chore: trigger

4ccb39e

Signed-off-by: gatici <[email protected]>

chore: trigger

0a440da

Signed-off-by: gatici <[email protected]>

chore: trigger

a72c476

Signed-off-by: gatici <[email protected]>

chore: trigger

9bcef95

Signed-off-by: gatici <[email protected]>

chore: use microk8s

b53bc05

Signed-off-by: gatici <[email protected]>

chore: fix typo

46ff136

Signed-off-by: gatici <[email protected]>

chore: remove metallb plugin

07a0bd3

Signed-off-by: gatici <[email protected]>

fix: Docker tag

4eed1c4

Signed-off-by: gatici <[email protected]>

fix: image tag in run-aiab

e707035

Signed-off-by: gatici <[email protected]>

chore: set alias

acac0b8

Signed-off-by: gatici <[email protected]>

chore: set alias and export kubeconfig

bb627d8

Signed-off-by: gatici <[email protected]>

fix: docker repository in Makefile

630167e

Signed-off-by: gatici <[email protected]>

gatici force-pushed the update-gha-for-all-branches branch 2 times, most recently from 1b3676d to 630167e Compare January 14, 2025 11:17

chore: use sudo in alias

0f39f11

Signed-off-by: gatici <[email protected]>

gab-arrobo requested changes Jan 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update gha in main #374

chore: update gha in main #374

gatici commented Dec 19, 2024 •

edited

Loading

gatici commented Dec 19, 2024

gab-arrobo Dec 19, 2024

gab-arrobo commented Dec 20, 2024

ghislainbourgeois left a comment

gatici commented Dec 20, 2024

gab-arrobo commented Dec 26, 2024

gatici commented Jan 7, 2025 •

edited

Loading

gab-arrobo commented Jan 13, 2025

gatici commented Jan 14, 2025

gab-arrobo Jan 10, 2025

gab-arrobo Jan 10, 2025

gab-arrobo Jan 10, 2025

gab-arrobo Jan 10, 2025

gab-arrobo Jan 15, 2025

		# Copyright 2023 Canonical Ltd.
		# Copyright 2024 Canonical Ltd.

	sudo microk8s kubectl config view --raw > $HOME/.kube/config
	microk8s kubectl config view --raw > $HOME/.kube/config

	yq -i '.5g-control-plane.images \|= {"amf": "localhost:32000/5gc-amf:amf-testing"}' sd-core-5g-values.yaml && \
	yq -i '.5g-control-plane.images.tags \|= {"amf": "localhost:32000/5gc-amf:amf-testing"}' sd-core-5g-values.yaml && \

chore: update gha in main #374

Are you sure you want to change the base?

chore: update gha in main #374

Conversation

gatici commented Dec 19, 2024 • edited Loading

gatici commented Dec 19, 2024

gab-arrobo Dec 19, 2024

Choose a reason for hiding this comment

gab-arrobo commented Dec 20, 2024

ghislainbourgeois left a comment

Choose a reason for hiding this comment

gatici commented Dec 20, 2024

gab-arrobo commented Dec 26, 2024

gatici commented Jan 7, 2025 • edited Loading

gab-arrobo commented Jan 13, 2025

gatici commented Jan 14, 2025

gab-arrobo Jan 10, 2025

Choose a reason for hiding this comment

gab-arrobo Jan 10, 2025

Choose a reason for hiding this comment

gab-arrobo Jan 10, 2025

Choose a reason for hiding this comment

gab-arrobo Jan 10, 2025

Choose a reason for hiding this comment

gab-arrobo Jan 15, 2025

Choose a reason for hiding this comment

gatici commented Dec 19, 2024 •

edited

Loading

gatici commented Jan 7, 2025 •

edited

Loading