URI / language conflict in item metadata

[allanaaa]

While testing #2248, I noticed that some value-content spans have an extra empty line of space on the bottom. This is actually a bit of margin-right that gets added when the value is a not-only-child.

I'm not clear on what this is intended to do (i.e. what could come after the value-content), but this will apply to a dereferenceable URI when a language tag is included at the top left. The bumping of this little margin onto a new line seems to be an unintended interaction when the URI dereferencer is on and it loads an empty "uri-dereferencer-container" container.

So, the top two values (Contributor and Spatial Coverage) have an extra line, where the multiple entries under Author do not.

I think the only thing that loads after value-content is the annotations:

So, the annotations end up on a new line when we usually want them inline with the value.

It's clear that not-only-child isn't the right selector for this.

This is probably related to #2038 and getting a definitive order & logic for all potential elements in the item metadata.

[kimisgold]

Quick question, which browser were you using for these screenshots? I'm no seeing this spacing in Firefox, but I see it in Chrome. Does this line up with your what you're seeing?

[allanaaa]

I'm seeing it in both Firefox and Chrome:

http://dev.omeka.org/amayer/amayer-s/omeka-s/s/my-omeka-s-site/item/24030#lg=1&slide=0

[kimisgold]

On my end, it looks like there's an empty container for URI dereferencer content that's taking up space. Once the URI dereferencer toggle is activated, that container is populated. When the toggle is used again to collapse the content, that container is hidden and the extra space goes away. On values that have annotations, the annotation toggle becomes inline after the URI dereferencer content appears at least once. If that's the case, it might be that URI dereferencer needs to adjust how it manages its content container visibility.

[kimisgold]

I'm not clear on what this is intended to do (i.e. what could come after the value-content)

Metadata browse links ("See all items with this value").

I noticed that this seems to be a style specific to the cozy theme, so I've adjusted the css rule to only provide the right margin if the value content is the last child in its container. If you spot this in any other themes, let me know.

[allanaaa]

I'm not clear on what this is intended to do (i.e. what could come after the value-content)

Metadata browse links ("See all items with this value").

No, the MB browse links are inside the value-content span.

I've just updated all my themes. This is in The Daily.

[allanaaa]

Also, the thumbnail next to the linked resource "National Mall Items" is messing with the line height, so the MB browse link is off-kilter, in both Cozy and Daily:

[allanaaa]

Both problems are also in Center Row:

[allanaaa]

Separate problem with the URI Dereferencer collapsed container in Freedom and Lively - they are displaying as empty boxes with borders rather than being hidden until the toggle is clicked.

I'm starting to think there is a module-based solution to all these problems, as you said above @kimisgold:

it might be that URI dereferencer needs to adjust how it manages its content container visibility.

If not, we can tag Nelson in to look at these two themes.

[kimisgold]

I think I'm going to draft a solution in UriDereferencer. I'll open an issue there and tag this thread.