Fix Packet Acknowledgment & Retry Mechanism #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed retry mechanism Doubles the delay between each attempt to moderate the load (Exponential backoff) Increases the number of retries to 8 Portions are removed after maximum attempts
htht2001
deleted the
correction-Packet-Acknowledgment-&-Retry-Mechanism
branch
htht2001
restored the
correction-Packet-Acknowledgment-&-Retry-Mechanism
branch
|
I accidentally closed the request |
|
Hi @htht2001, Thank you for your contribution and for addressing the retry mechanism in this PR! 🚀 We wanted to inform you that we have just released an update to ensure compatibility with the latest ESPHome version. This update includes some changes to the code structure that may impact your implementation. To align your PR with the new updates:
Let us know if you need any assistance with this process. We truly appreciate your work and look forward to merging this PR after testing and adjustments are completed. 🙌 Thank you again for your efforts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Description
What does this Pull Request do?
✨ Key Changes
This is a draft retry mechanism fix, on the way to implementing all the changes addressed in #93
🔗 Related Issues
Fixes: #229
Related: #206
✅ Checklist
Please ensure the following before submitting your PR:
🌐 Environment Information
🔢 Versions
🧩 Devices
🧪 Test Plan
How were these changes tested?
🔍 Logs
🛠️ YAML Configuration
# Please provide the relevant YAML configuration you used for testing this PR