Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add extra token request params for authorization code flow #199

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dominikklein
Copy link

@dominikklein dominikklein commented Feb 13, 2025

In addition to the PR I improved the related test case.

I wrongly thought that the client_id needs also to be added, but this is already done in the rack oauth2 client.

With this e.g. the usage of Auth0 would also work out-of-the-box with this gem.

@dominikklein
Copy link
Author

@bufferoverflow Maybe you can check if this is the way to go :-)

@dominikklein
Copy link
Author

I wrongly thought that the client_id needs also to be added, but this is already done in the rack oauth2 client.

Ok, I was wrong, with basic client_auth_method it's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant