Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PENG-1676] Add re-submit endpoint to API's job_submissions router #643

Merged

Conversation

fschuch
Copy link
Member

@fschuch fschuch commented Oct 30, 2024

What

  • Add a 're-submit' endpoint to the job_submissions routerre-submission
  • Add unit tests
  • Update documentation

Why

The jobbergate-api needs an endpoint that allows a client to re-submit a job_submission with exactly the same parameters as a previous submission.

Tasks:


Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (d71b539) to head (b943930).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
+ Coverage   92.54%   92.57%   +0.02%     
==========================================
  Files          85       85              
  Lines        4465     4483      +18     
==========================================
+ Hits         4132     4150      +18     
  Misses        333      333              
Flag Coverage Δ
agent 92.80% <ø> (ø)
api 95.32% <ø> (+0.02%) ⬆️
cli 88.60% <ø> (+0.04%) ⬆️
core 96.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dusktreader dusktreader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

@fschuch fschuch force-pushed the fschuch/PENG-1676--add-resubmit-api-endpoint-to-job-submissions branch from b95b9c6 to 54f3dc0 Compare November 6, 2024 17:23
@fschuch fschuch marked this pull request as ready for review November 7, 2024 13:56
Copy link
Member

@dusktreader dusktreader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Added a few comments for you.

@fschuch fschuch force-pushed the fschuch/PENG-1676--add-resubmit-api-endpoint-to-job-submissions branch from 7883b10 to b943930 Compare November 8, 2024 18:25
@fschuch fschuch merged commit 6350267 into main Nov 8, 2024
13 checks passed
@fschuch fschuch deleted the fschuch/PENG-1676--add-resubmit-api-endpoint-to-job-submissions branch November 8, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants