-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PENG-1676] Add re-submit endpoint to API's job_submissions router #643
[PENG-1676] Add re-submit endpoint to API's job_submissions router #643
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
+ Coverage 92.54% 92.57% +0.02%
==========================================
Files 85 85
Lines 4465 4483 +18
==========================================
+ Hits 4132 4150 +18
Misses 333 333
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
b95b9c6
to
54f3dc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Added a few comments for you.
7883b10
to
b943930
Compare
What
Why
The jobbergate-api needs an endpoint that allows a client to re-submit a job_submission with exactly the same parameters as a previous submission.
Tasks
:Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.