Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase develop #102

Merged
merged 1 commit into from
Jun 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [2.2.1]

### Changed
- Replaced the storage slot used for ImplementationAuthority on the proxies, to avoid conflict with ERC-1822 on
block explorers. By using the same storage slot, the explorers were identifying this proxy as an ERC-1822, while
it's a different implementation here, the storage slot is not used to store the address of the implementation but
the address to ImplementationAuthority contract that references the implementation

## [2.2.0]

### Added
Expand Down
4 changes: 2 additions & 2 deletions contracts/proxy/IdentityProxy.sol
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ contract IdentityProxy {

// solhint-disable-next-line no-inline-assembly
assembly {
sstore(0xc5f16f0fcc639fa48a6947836d9850f504798523bf8c9a3a87d5876cf622bcf7, _implementationAuthority)
sstore(0x821f3e4d3d679f19eacc940c87acf846ea6eae24a63058ea750304437a62aafc, _implementationAuthority)
}

address logic = IImplementationAuthority(_implementationAuthority).getImplementation();
Expand Down Expand Up @@ -59,7 +59,7 @@ contract IdentityProxy {
address implemAuth;
// solhint-disable-next-line no-inline-assembly
assembly {
implemAuth := sload(0xc5f16f0fcc639fa48a6947836d9850f504798523bf8c9a3a87d5876cf622bcf7)
implemAuth := sload(0x821f3e4d3d679f19eacc940c87acf846ea6eae24a63058ea750304437a62aafc)
}
return implemAuth;
}
Expand Down
2 changes: 1 addition & 1 deletion contracts/version/Version.sol
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ contract Version {
*/
function version() external pure returns (string memory) {
// version 2.2.0
return "2.2.0";
return "2.2.1";
}
}
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@onchain-id/solidity",
"version": "2.2.0",
"version": "2.2.1",
"description": "EVM solidity smart contracts for Blockchain OnchainID identities.",
"files": [
"artifacts",
Expand Down
2 changes: 1 addition & 1 deletion test/identities/init.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@ describe('Identity', () => {
it('should return the version of the implementation', async () => {
const {identityImplementation} = await loadFixture(deployIdentityFixture);

expect(await identityImplementation.version()).to.equal('2.2.0');
expect(await identityImplementation.version()).to.equal('2.2.1');
});
});
Loading