Fixed global search #498
Merged
Fixed global search #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinlu3
reviewed
Feb 18, 2025
| if (criteria.getName() != null && criteria.getName().getContains() != null) { | ||
| specification = specification.or((root, _ignore, cb) -> { | ||
| return cb.like( | ||
| cb.lower(root.get(Drug_.name).as(String.class)), |
There was a problem hiding this comment.
MySQL LIKE operator should already compare ignoring case right? Does that mean we don't need cb.lower(root.get(Drug_.name).as(String.class)), instead we can trim to just root.get(Drug_.name).as(String.class)?
calvinlu3
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/oncokb/oncokb-pipeline/issues/657
Currently we're getting an error
Parameter 1 of function 'upper()' has type 'STRING', but argument is of type 'java.lang.String' mapped to 'CLOB'The name column in the drug table is of type
longtextwhich apparently is aCLOBtype so the name column needs to be explicitly casted to a string type.