Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCLomatic] Fix the __CUDA_ARCH__ parsing error when the __CUDA_ARCH__ defined in a macro directive. #1986

Merged
merged 21 commits into from
Jun 12, 2024
Merged

[SYCLomatic] Fix the __CUDA_ARCH__ parsing error when the __CUDA_ARCH__ defined in a macro directive. #1986

merged 21 commits into from
Jun 12, 2024

Conversation

ShengchenJ
Copy link
Contributor

No description provided.

@ShengchenJ ShengchenJ requested a review from a team as a code owner May 15, 2024 07:14
@ShengchenJ ShengchenJ requested review from intwanghao and wenhuiNi May 15, 2024 07:14
intwanghao
intwanghao approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@intwanghao intwanghao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShengchenJ ShengchenJ marked this pull request as draft May 30, 2024 00:54
ShengchenJ added 2 commits May 30, 2024 11:52
@ShengchenJ
update
f93dd7d 
Signed-off-by: Chen, Sheng S <[email protected]>
@ShengchenJ
up
8e77bba 
Signed-off-by: Chen, Sheng S <[email protected]>
@ShengchenJ ShengchenJ marked this pull request as ready for review May 30, 2024 05:16
intwanghao
intwanghao approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@intwanghao intwanghao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShengchenJ
update
eeab1ce 
Signed-off-by: Chen, Sheng S <[email protected]>
@ziranzha ziranzha merged commit 11e3d5e into oneapi-src:SYCLomatic Jun 12, 2024
21 checks passed
@ShengchenJ ShengchenJ deleted the fix_cuda_arch branch June 13, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intwanghao intwanghao intwanghao approved these changes

@ziranzha ziranzha ziranzha approved these changes

@wenhuiNi wenhuiNi Awaiting requested review from wenhuiNi wenhuiNi is a code owner automatically assigned from oneapi-src/syclomatic-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShengchenJ @intwanghao @ziranzha