[SYCLomatic] Enable migration for CUBLASLT_EPILOGUE_DGELU & EPILOGUE_BGRADB #2449

abhilash1910 · 2024-11-05T12:43:33Z

zhiweij1 · 2024-11-06T07:26:07Z

clang/runtime/dpct-rt/include/dpct/blas_gemm_utils.hpp

+    float alpha, float beta) {
+
+  auto alg = ::dnnl::algorithm::eltwise_gelu_erf;
+  const memory_desc_ext &dst_desc = new memory_desc_ext();


where to "delete" dst_desc and src_desc?

clang/runtime/dpct-rt/include/dpct/blas_gemm_utils.hpp

zhiweij1 · 2024-11-06T07:27:25Z

clang/runtime/dpct-rt/include/dpct/blas_gemm_utils.hpp

@@ -44,6 +44,19 @@ using matmul_desc_ptr = matmul_desc_t *;
 class transform_desc_t;
 using transform_desc_ptr = transform_desc_t *;

+template <typename primitive_type, typename... args_type>
+inline
+typename primitive_type::primitive_desc dgelu_epilogue_(


The function name looks like a type name, please refine it.

zhiweij1 · 2024-11-06T07:29:20Z

clang/runtime/dpct-rt/include/dpct/blas_gemm_utils.hpp

+  const memory_desc_ext &dst_desc = new memory_desc_ext();
+  const memory_desc_ext &src_desc = new memory_desc_ext();
+  return create_primitive_desc<primitive_type>(
+                    ::dnnl::prop_kind::backward, alg, src_desc.get_desc(),


For src_desc and dst_desc, is it OK to pass to the create_primitive_desc directly?
No need to fill data?

clang/runtime/dpct-rt/include/dpct/blas_gemm_utils.hpp

zhiweij1

Please refine the PR.

zhiweij1

Please submit E2E test PR first.

zhiweij1 · 2024-12-04T23:51:46Z

clang/runtime/dpct-rt/include/dpct/blas_gemm_utils.hpp

+typename primitive_type::primitive_desc sync_gelu_backward(
+    float alpha, float beta, const::dnnl::memory_desc_ext &src_desc,
+    const ::dnnl::memory_desc_ext &dest_desc) {
+
+  auto alg = ::dnnl::algorithm::eltwise_gelu_erf;
+  return create_primitive_desc<primitive_type>(
+                    ::dnnl::prop_kind::backward, alg, src_desc.get_desc(),
+                    dst_desc.get_desc(), alpha, beta);
+}
+
+template <typename primitive_type, typename... args_type>
+inline
+typename primitive_type::primitive_desc bias_backward(
+    float alpha, float beta, const dnnl::memory_desc_ext &src_desc,
+    const ::dnnl::memory_desc_ext &dest_desc) {
+
+  auto alg = ::dnnl::algorithm::reduction_sum;
+  return create_primitive_desc<primitive_type>(
+                    ::dnnl::prop_kind::backward, alg, src_desc.get_desc(),
+                    dst_desc.get_desc(), alpha, beta);
+}


For backward primitives, it needs a forward primitive object as a constructor argument. https://github.com/oneapi-src/oneDNN/blob/main/include/oneapi/dnnl/dnnl.hpp#L7476

abhilash1910 · 2024-12-06T03:16:30Z

Transfer to @zhiweij1 . Thanks

abhilash1910 requested a review from a team as a code owner November 5, 2024 12:43

abhilash1910 requested review from the-slow-one and intwanghao November 5, 2024 12:43