-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCLomatic] Fix unsuccessful compilation of dpct::load_kernel_library_mem
due to failed argument cast
#2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiweij1
reviewed
Nov 29, 2024
zhiweij1
reviewed
Nov 29, 2024
the-slow-one
commented
Nov 29, 2024
Co-authored-by: Jiang, Zhiwei <[email protected]>
the-slow-one
commented
Nov 29, 2024
the-slow-one
commented
Nov 29, 2024
zhiweij1
approved these changes
Nov 29, 2024
TejaX-Alaghari
approved these changes
Nov 29, 2024
ziranzha
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the CUDA source and migrated SYCL code.
icpx
fails to compile the migrated code with following error.This PR fixes this issue by explicitly casting the pointer the expected type.
Signed-off-by: Deepak Raj H R