[PTX] Enable migration of ldmatrix #2692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiweij1
changed the title
tomflinda
reviewed
Mar 11, 2025
tomflinda
reviewed
Mar 11, 2025
tomflinda
reviewed
Mar 11, 2025
tomflinda
reviewed
Mar 11, 2025
TejaX-Alaghari
force-pushed
the
ptx
branch
5 times, most recently
from
bd88679 to
4492ec9
Compare
ziranzha
reviewed
Mar 14, 2025
| @@ -557,12 +557,15 @@ bool SYCLGenBase::emitVectorType(const InlineAsmVectorType *T) { | |||
| OS() << ", "; | |||
| switch (T->getKind()) { | |||
| case InlineAsmVectorType::v2: | |||
| case InlineAsmVectorType::x1: | |||
There was a problem hiding this comment.
What's the relation between ptx x1 x2 x4 and vector size? And should have a lit test for it.
There was a problem hiding this comment.
In "xn", n refers to the number of output args being passed to the instruction
There seems to be no lit test added for "vn", so I'm not sure about lit test for this scenario
What do you advice?
There was a problem hiding this comment.
By the way, I don't see the usage of the vector size, is that right?
ziranzha
reviewed
Mar 14, 2025
ziranzha
reviewed
Mar 14, 2025
ziranzha
reviewed
Mar 14, 2025
ziranzha
reviewed
Mar 20, 2025
| OS() << ", "; | ||
| if (const auto *VE = | ||
| dyn_cast<InlineAsmVectorExpr>(Inst->getOutputOperand())) { | ||
| for (unsigned Inst = 0; Inst != VE->getNumElements(); ++Inst) { |
There was a problem hiding this comment.
Should we check the vector size satisfy the instruction requirement?
ziranzha
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the migration of ldmatrix PTX ASM API