Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCLomatic] Fix the migration of __hmul2 and __hsub2 when --use-dpcpp-extensions=intel_device_math is specified #2728

Merged
merged 7 commits into from
Mar 25, 2025
Merged

[SYCLomatic] Fix the migration of __hmul2 and __hsub2 when --use-dpcpp-extensions=intel_device_math is specified #2728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7744604
WIP
zhiweij1 Mar 17, 2025
196082f
Merge remote-tracking branch 'origin/SYCLomatic' into fp16andbf16
zhiweij1 Mar 20, 2025
5c896cd
wip
zhiweij1 Mar 20, 2025
527059c
1
zhiweij1 Mar 20, 2025
b66357f
Add test
zhiweij1 Mar 21, 2025
4b558f7
Merge remote-tracking branch 'origin/SYCLomatic' into fp16andbf16
zhiweij1 Mar 21, 2025
aa0fbb0
Fix
zhiweij1 Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 36 additions & 20 deletions clang/lib/DPCT/RulesLang/Math/RewriterHalf2ArithmeticFunctions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,22 +261,30 @@ RewriterMap dpct::createHalf2ArithmeticFunctionsRewriterMap() {
makeCallArgCreatorWithCall(2)),
LITERAL("{0.f, 0.f}"), LITERAL("{1.f, 1.f}"))))))
// __hmul2
MATH_API_REWRITER_DEVICE(
"__hmul2",
MATH_API_DEVICE_NODES(
EMPTY_FACTORY_ENTRY("__hmul2"),
MATH_API_SPECIFIC_ELSE_EMU(
CheckArgType(0, "__half2"),
MATH_API_REWRITER_DEVICE_OVERLOAD(
CheckArgType(0, "__half2"),
MATH_API_REWRITERS_V2(
"__hmul2",
MATH_API_REWRITER_PAIR(
math::Tag::math_libdevice,
HEADER_INSERT_FACTORY(
HeaderType::HT_SYCL_Math,
CALL_FACTORY_ENTRY("__hmul2",
CALL(MapNames::getClNamespace() +
"ext::intel::math::hmul2",
ARG(0), ARG(1))))),
EMPTY_FACTORY_ENTRY("__hmul2"),
BINARY_OP_FACTORY_ENTRY("__hmul2", BinaryOperatorKind::BO_Mul,
makeCallArgCreatorWithCall(0),
makeCallArgCreatorWithCall(1))))
MATH_API_REWRITER_PAIR(
math::Tag::emulation,
BINARY_OP_FACTORY_ENTRY("__hmul2", BinaryOperatorKind::BO_Mul,
makeCallArgCreatorWithCall(0),
makeCallArgCreatorWithCall(1)))),
MATH_API_REWRITERS_V2(
"__hmul2",
MATH_API_REWRITER_PAIR(
math::Tag::emulation,
BINARY_OP_FACTORY_ENTRY("__hmul2", BinaryOperatorKind::BO_Mul,
makeCallArgCreatorWithCall(0),
makeCallArgCreatorWithCall(1)))))
// __hmul2_rn
MATH_API_REWRITER_DEVICE(
"__hmul2_rn",
Expand Down Expand Up @@ -343,22 +351,30 @@ RewriterMap dpct::createHalf2ArithmeticFunctionsRewriterMap() {
UNARY_OP_FACTORY_ENTRY("__hneg2", UnaryOperatorKind::UO_Minus,
makeCallArgCreatorWithCall(0))))
// __hsub2
MATH_API_REWRITER_DEVICE(
"__hsub2",
MATH_API_DEVICE_NODES(
EMPTY_FACTORY_ENTRY("__hsub2"),
MATH_API_SPECIFIC_ELSE_EMU(
CheckArgType(0, "__half2"),
MATH_API_REWRITER_DEVICE_OVERLOAD(
CheckArgType(0, "__half2"),
MATH_API_REWRITERS_V2(
"__hsub2",
MATH_API_REWRITER_PAIR(
math::Tag::math_libdevice,
HEADER_INSERT_FACTORY(
HeaderType::HT_SYCL_Math,
CALL_FACTORY_ENTRY("__hsub2",
CALL(MapNames::getClNamespace() +
"ext::intel::math::hsub2",
ARG(0), ARG(1))))),
EMPTY_FACTORY_ENTRY("__hsub2"),
BINARY_OP_FACTORY_ENTRY("__hsub2", BinaryOperatorKind::BO_Sub,
makeCallArgCreatorWithCall(0),
makeCallArgCreatorWithCall(1))))
MATH_API_REWRITER_PAIR(
math::Tag::emulation,
BINARY_OP_FACTORY_ENTRY("__hsub2", BinaryOperatorKind::BO_Sub,
makeCallArgCreatorWithCall(0),
makeCallArgCreatorWithCall(1)))),
MATH_API_REWRITERS_V2(
"__hsub2",
MATH_API_REWRITER_PAIR(
math::Tag::emulation,
BINARY_OP_FACTORY_ENTRY("__hsub2", BinaryOperatorKind::BO_Sub,
makeCallArgCreatorWithCall(0),
makeCallArgCreatorWithCall(1)))))
// __hsub2_rn
MATH_API_REWRITER_DEVICE(
"__hsub2_rn",
Expand Down
4 changes: 4 additions & 0 deletions clang/test/dpct/math/bfloat16/bfloat16_ext.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ __global__ void kernelFuncBfloat162Arithmetic() {
__nv_bfloat162 bf162, bf162_1, bf162_2;
// CHECK: bf162 = bf162_1 / bf162_2;
bf162 = __h2div(bf162_1, bf162_2);
// CHECK: bf162 = bf162_1 * bf162_2;
bf162 = __hmul2(bf162_1, bf162_2);
// CHECK: bf162 = bf162_1 - bf162_2;
bf162 = __hsub2(bf162_1, bf162_2);
}

__global__ void kernelFuncBfloat16Comparison() {
Expand Down