Fix the bug of compiler wrong set in sample cmakelists #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update README.md * Update sample.json * Update sample.json
* Update README.md * Update README.md * Update README.md * Update lu_solve_omp_offload_optimized.F90 * FPGA: Revert "Remove fpga_register annotations from fifo_sort" (oneapi-src#2370) This reverts commit 75397ca that initially went in to prevent an error from being emitted to customers. * Update openmp_sample.f90 * Update openmp_sample.f90 (oneapi-src#2371) * Update requirements.txt * Update inc_sample_tensorflow.ipynb * Update inc_quantize_model.py * Update README.md * Update release.json * Fix ONSAM-1905 (oneapi-src#2376) * FPGA: re-enable the fft2d sample (oneapi-src#2381) This sample is previously disabled in oneapi-src#2355. Re-enabling for better test coverage of the sample. * FPGA: Bug fixes for the fft2d sample (oneapi-src#2382) 1. Fix array index out of bound in function `ReorderData` 2. Fix use of uninitialized array `fft_delay_elements` * Add explicit header (oneapi-src#2367) * “inlinePTX_with_codepin” (oneapi-src#2372) Signed-off-by: AvijitBag07 <[email protected]> Co-authored-by: AvijitBag07 <[email protected]> * Adding 2 new openACC-openMP migrated samples (oneapi-src#2373) * New openmp samples * Updated New samples * Adding pSTL-offload sample (oneapi-src#2374) * pSTL offload sample * pSTL offload sample * minor fixes to multi-gpu training (oneapi-src#2377) * Fix crashes in f_use_device_addr_01, dgemm_pad_f_01, dgemm_dispatch_f (oneapi-src#2378) * Fix crashes in f_use_device_addr_01, dgemm_pad_f_01, and dgemm_dispatch_f (ONSAM-1918). * Fix crashes in f_use_device_addr_01, dgemm_pad_f_01, dgemm_dispatch_f * Fix crashes in f_use_device_addr_01, dgemm_pad_f_01, dgemm_dispatch_f * Add explicit headers (oneapi-src#2366) * FPGA: correct 'categories' for hls flow/interfaces code samples (oneapi-src#2383) Correct 'categories' for hls flow/interfaces code samples so they group together nicely in the sample browser * FPGA: Remove unused memory allocation in the gzip sample (oneapi-src#2386) The gzip code sample included a memory allocation of the size of the file to be compressed, which was issued for every repeated iteration of the kernel. This led to increasingly large host memory allocation when the file to compress was increasing in size. However, the allocated memory was never used. This change therefore removes the unneeded allocation. * FPGA: Update gzip throughput experiment date * FPGA: Correct performance testing date in PCA * FPGA: Correct performance testing date in matmul * FPGA: Correct performance testing date in CRR * FPGA: Correct performance testing date in QRD * FPGA: Correct performance testing date in Cholesky inversion * FPGA: Correct performance testing date in Cholesky * FPGA: Add missing cmath include in the hardware_reuse sample (oneapi-src#2387) * Update sample.json and remove unused code * forgot this requirements.txt earlier * Update README.md * Update README.md * Update sample.json * Update sample.json --------- Signed-off-by: AvijitBag07 <[email protected]> Co-authored-by: Jimmy Wei <[email protected]> Co-authored-by: Justin Rosner <[email protected]> Co-authored-by: Zhiqiang Ma <[email protected]> Co-authored-by: intel-jisheng1 <[email protected]> Co-authored-by: IgorOchocki <[email protected]> Co-authored-by: AvijitBag07 <[email protected]> Co-authored-by: AvijitBag07 <[email protected]> Co-authored-by: vidyalathabadde <[email protected]> Co-authored-by: Shwetha-Selma <[email protected]> Co-authored-by: Rakshith <[email protected]> Co-authored-by: nawalcopty <[email protected]> Co-authored-by: Paul White <[email protected]> Co-authored-by: yuguen-intel <[email protected]>
…i-src#2414) This reverts commit 46c43ee.
* added `trust_remote_code=True` HF load_dataset * updated numba_dpex kernel call to use new API * fix numba_dpex typo * Updated TF & TF_hub api, deleted `models` directory.
Signed-off-by: Ong, Frankie Wei Quan <[email protected]>
Signed-off-by: Fong Jian Tan <[email protected]>
Signed-off-by: Ang, Yee Teng <[email protected]>
Signed-off-by: Ong, Frankie Wei Quan <[email protected]>
Signed-off-by: Ang, Yee Teng <[email protected]>
Signed-off-by: Fong Jian Tan <[email protected]>
Signed-off-by: Fong Jian Tan <[email protected]>
…erving_release [release/2024.2_AITools] Remove TF Serving
…Tools removed notebook execution command
…arted [release/2024.2_AITools] updated ITEX Getting Started sample
Update README.md Modin GS
Update README.md XGBoost GS
Update README.md daal4py GS
Update readme.md sklearnex GS
Update README.md modin vs pandas
…ools 2024.2 AI Tools second set of updates
…ools README updates for 2024.2 AI Tools release
…atch Remove deprecated target variant dispatch from oneMKL sample
Signed-off-by: michael vincerra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
In the DirectProgramming/C++/StructuredGrids/iso3dfd_omp_offload/src/CMakeLists.txt, the default cmake instructions shown in the official guidance cmake -DVERIFY_RESULTS=0 .. cannot really successfully make-build the project successfully and report the below messages, indicating that the compiler is not set properly.
~/Documents/oneAPI-samples/DirectProgramming/C++/StructuredGrids/iso3dfd_omp_offload/src/build$ make -j
[ 25%] Building CXX object CMakeFiles/iso3dfd.dir/utils.o
[ 50%] Building CXX object CMakeFiles/iso3dfd.dir/iso3dfd.o
[ 75%] Building CXX object CMakeFiles/iso3dfd.dir/iso3dfd_verify.o
c++: error: unrecognized command-line option ‘-fiopenmp’; did you mean ‘-fopenmp’?
c++: error: unrecognized command-line option ‘-fiopenmp’; did you mean ‘-fopenmp’?
c++: error: unrecognized command-line option ‘-fiopenmp’; did you mean ‘-fopenmp’?
c++: error: unrecognized command-line option ‘-fopenmp-targets=spir64’
make[2]: *** [CMakeFiles/iso3dfd.dir/build.make:90: CMakeFiles/iso3dfd.dir/utils.o] Error 1
make[2]: *** Waiting for unfinished jobs....
c++: error: unrecognized command-line option ‘-fopenmp-targets=spir64’
c++: error: unrecognized command-line option ‘-fopenmp-targets=spir64’
make[2]: *** [CMakeFiles/iso3dfd.dir/build.make:76: CMakeFiles/iso3dfd.dir/iso3dfd.o] Error 1
make[2]: *** [CMakeFiles/iso3dfd.dir/build.make:104: CMakeFiles/iso3dfd.dir/iso3dfd_verify.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:84: CMakeFiles/iso3dfd.dir/all] Error 2
make: *** [Makefile:91: all] Error 2
In the CMakeLists file, the 3rd line should be changed from set(CMAKE_CXX_COMPILER "icpx") to set(CMAKE_CXX_COMPILER icpx). Or we should explicitly declare the compiler options.
Fixes Issue#
External Dependencies
List any external dependencies created as a result of this change.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration