Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed requirements.txt reference from README file #2621

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

jafraustro
Copy link

Existing Sample Changes

Description

Removed requirements.txt reference since is an unnecessary step to run the sample in README file

Fixes Issue# Improve documentation

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Command Line
  • oneapi-cli
  • Visual Studio
  • Eclipse IDE
  • VSCode
  • When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

Remove unnecessary step to run the sample in README file

Signed-off-by: dggaytan <[email protected]>
Signed-off-by: eromomon <[email protected]>
@Ankur-singh
Copy link
Contributor

A small suggestion, can't we just delete requirements.txt file in Modin_GettingStarted directory and add update the sample.json file accordingly? Please refer the sample.json file in Modin_Vs_Pandas directory.

Use modin environment instead of base environment to run the samples

Signed-off-by: jafraustro <[email protected]>
@jafraustro
Copy link
Author

A small suggestion, can't we just delete requirements.txt file in Modin_GettingStarted directory and add update the sample.json file accordingly? Please refer the sample.json file in Modin_Vs_Pandas directory.

Hi @Ankur-singh,

We made some corrections to our previous commit.

  • Tests should be run in modin env to avoid install modin from pip
  • Base environment has matplotlib, for this reason we remove the requirements.txt file but matplotlib is not present in the modin environment, so we add requirements.txt file again.

@Ankur-singh
Copy link
Contributor

I mean to say, use pip install matplotlib in sample.json. This will make it explicit.

@jafraustro
Copy link
Author

Done

@Ankur-singh
Copy link
Contributor

@jafraustro requirements.txt file is no longer required, right?

@jafraustro
Copy link
Author

Hi @Ankur-singh,
I make it explicit in the Readme file and removed the requirements.txt file.

Matplotlib is not part of the AI tool selector commands for 2025.1.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants