Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uv conversion additional samples GettingStarted, Features, End-to-End #2623

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Uv conversion additional samples GettingStarted, Features, End-to-End #2623

wants to merge 3 commits into from

Conversation

eleemhui
Copy link

@eleemhui eleemhui commented Mar 8, 2025 •
edited
Loading

Existing Sample Changes

Description

ONSAM 1917 Continued (17 total in this PR)
In these changes we are using UV to manage the python dependencies, kernels, and venv.
Each test will be isolated from all other tests and packages added/changed/removed will not affect later tests.
pyproject.toml files have been added to each sample test which list all the dependencies and required versions (takes the place of the requirements.txt).
Adds uv.lock file to maintain consistency of packages being run on any environment.
Removes all calls to 'conda' in the sample.json files as well as dependence on the AI Tools Offline Installer
Fixes Issue#

Signed-off-by: Solano Saurez, Hector [email protected]
Co-authored-by: Allan Mora B [email protected]
Co-authored-by: Mora Jimenez, Kevin [email protected]
Co-authored-by: Edgar Parra [email protected]

The following test cases are completed and tested:
AI-and-Analytics/Getting-Started-Samples
IntelPython_daal4py_GettingStarted/
IntelPython_XGBoost_GettingStarted/
IntelTensorFlow_GettingStarted/
Modin_GettingStarted/
Modin_Vs_Pandas/

AI-and-Analytics/Features-and-Functionality
INC_QuantizationAwareTraining_TextClassification/
Intel_Extension_For_SKLearn_Performance_SVC_Adult/
IntelPython_daal4py_DistributedKMeans/
IntelPython_daal4py_DistributedLinearRegression/
IntelPython_XGBoost_daal4pyPrediction/
IntelTensorFlow_Enabling_Auto_Mixed_Precision_for_TransferLearning/
IntelTensorFlow_for_LLMs/
IntelTensorFlow_Horovod_Distributed_Deep_Learning/
IntelTensorFlow_ModelZoo_Inference_with_FP32_Int8/
IntelTensorFlow_PerformanceAnalysis/
IntelTensorFlow_TextGeneration_with_LSTM/

AI-and-Analytics/End-To-End
JobRecommendationSystem/

External Dependencies

None

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Implement fixes for ONSAM Jiras

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Command Line
  • oneapi-cli
  • Visual Studio
  • Eclipse IDE
  • VSCode
  • When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

@eleemhui
Uv conversion remaining samples (#4)
b65bf6a 
* uv for IntelTensorFlow_for_LLMs.
* uv for leveraging-intel-extension-for-tensorFlow-with-LSTM-for-text-generation
* uv for IntelTensorFlow_Horovod_Distributed_Deep_Learning
* uv for IntelTensorFlow_ModelZoo_Inference_with_FP32_Int8
* uv for IntelTensorFlow_PerformanceAnalysis
* add uv to IntelPython_XGBoost_daal4pyPrediction
* finished sample IntelTensorFlow_Enabling_Auto_Mixed_Precision_for_TransferLearning
* finished converting IntelPython_daal4py_DistributedLinearRegression
* finished converting IntelPython_daal4py_GettingStarted
* uv added to IntelPython_daal4py_DistributedKMeans
* uv for intelpython-xgboost-gettingstarted
* uv for intelTensorFlow_gettingstarted
* uv for moding_gettingstarted
* adding uv for moding_vs_pandas
* finished converting JobRecommendationSystem sample

---------
Signed-off-by: Solano Saurez, Hector <[email protected]>
Co-authored-by: Allan Mora B <[email protected]>
Co-authored-by: Mora Jimenez, Kevin <[email protected]>
Co-authored-by: Edgar Parra <[email protected]>
@aemorabr aemorabr mentioned this pull request Mar 14, 2025
Open
9 tasks
Ankur-singh
Ankur-singh reviewed Mar 14, 2025
View reviewed changes
AI-and-Analytics/Getting-Started-Samples/Modin_GettingStarted/sample.json Outdated
"env": [
"pip install uv==0.6.3",
"uv sync",
"uv run python -m ipykernel install --user --name=modin_gs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in progress

Ankur-singh
Ankur-singh reviewed Mar 14, 2025
View reviewed changes
AI-and-Analytics/Getting-Started-Samples/IntelTensorFlow_GettingStarted/pyproject.toml Outdated
]
license = {text = "MIT"}
readme = "README.md"
requires-python = ">=3.11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work for python==3.12. This should be fixed to 3.11, can you change it to requires-python = ">=3.11,<3.12"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in progress

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Ankur-singh
Ankur-singh reviewed Mar 14, 2025
View reviewed changes
AI-and-Analytics/Getting-Started-Samples/IntelTensorFlow_GettingStarted/pyproject.toml Outdated
Comment on lines 15 to 18
[dependency-groups]
dev = [
"ipykernel>=6.29.5",
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this since we only have python script in this sample, no notebook!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in progress

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Ankur-singh
Ankur-singh reviewed Mar 14, 2025
View reviewed changes
AI-and-Analytics/End-to-end-Workloads/JobRecommendationSystem/pyproject.toml Outdated
]
license = {text = "MIT"}
readme = "README.md"
requires-python = ">=3.11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't work for python 3.12. Need to limit the range.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In progress

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

eleemhui and others added 2 commits April 2, 2025 09:38
@eleemhui
merge upstream
48da1e6
@eleemhui
Pr2 fixes (#5)
ddc41c9 
* fix Modin_vs_Pandas
* fixed Modin_GettingStarted
* fixed IntelTensorFlow_GettingStarted
* fix IntelPython_daal4py_GettingStarted
* fix IntelPython_XGBoost_GettingStarted
* fix JobRecommendationSystem
* fix Intel_Extension_for_SKLearn_Performance_SVC_Adult
* fix IntelPython_daal4py_DistributedKMeans and IntelPython_daal4py_DistributedLinearRegression
* fix IntelPython_XGBoost_daal4pyPrediction
* fix IntelTensorFlow_Enabling_Auto_Mixed_Precision_for_TransferLearning and remove unnecessary ipykernel module
* fixed IntelTensorFlow_Horovod_Distributed_Deep_Learning
* update some versions
* clean metadata and output from notebooks
* fix IntelTensorFlow_TextGeneration_with_LSTM
* fix INC_QuantizationAwareTraining_TextClassification
* remove deprecated samples
@eleemhui
Copy link
Author

eleemhui commented Apr 2, 2025

Hello @Ankur-singh,
I've made quite a few updates to this branch and applied the changes you mentioned to as many as I could.
Some additional feedback would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ankur-singh Ankur-singh Ankur-singh left review comments

Assignees
No one assigned
Labels
Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eleemhui @Ankur-singh @jimmytwei