-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge v0.10.x into main #1032
Merge v0.10.x into main #1032
Conversation
Add strings with UMF version and useful CMake options that can be grepped in the following way: $ strings libumf.so | grep "@(#)" @(#) Intel(R) UMF version: 0.11.0-dev.git66.g89e3831d @(#) Intel(R) UMF CMake variables: "CMAKE_BUILD_TYPE:Debug,... Signed-off-by: Lukasz Dorau <[email protected]>
…rsion_and_all_UMF_CMake_variables Add strings with UMF version and useful CMake options
Add error messages when CUDA provider is disabled (UMF_BUILD_CUDA_PROVIDER is OFF). Signed-off-by: Lukasz Dorau <[email protected]>
Signed-off-by: Lukasz Dorau <[email protected]>
Signed-off-by: Lukasz Dorau <[email protected]>
Add error messages when L0 memory provider is disabled (UMF_BUILD_LEVEL_ZERO_PROVIDER is OFF). Signed-off-by: Lukasz Dorau <[email protected]>
…n_memory_providers_are_disabled Add error messages when memory providers are disabled
Co-authored-by: Łukasz Stolarczuk <[email protected]>
Set symbol versions 0.10 in def/map files
umfFixedMemoryProviderOps; | ||
umfFixedMemoryProviderParamsCreate; | ||
umfFixedMemoryProviderParamsDestroy; | ||
} UMF_0.10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure on this one - I based this on info from https://sourceware.org/binutils/docs/ld/VERSION.html
@@ -117,3 +114,9 @@ UMF_1.0 { | |||
local: | |||
*; | |||
}; | |||
|
|||
UMF_0.11 { | |||
umfFixedMemoryProviderOps; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have any other new symbols on main...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what about recent change in umf_memory_provider_ops_t struct and functions using it but we'll figure it out in backward comp. tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heh, I guess we have to figure it out, cause it's already failing on my test branch in UR 😄
https://github.com/oneapi-src/unified-runtime/actions/runs/12710368809/job/35431309282?pr=2546
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heh, I guess we have to figure it out, cause it's already failing on my test branch in UR 😄
https://github.com/oneapi-src/unified-runtime/actions/runs/12710368809/job/35431309282?pr=2546
@lukaszstolarczuk Is it still failing ?
|
||
VERSION 1.0 | ||
VERSION 0.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this one should be updated...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should match map file even if this is not used anywhere
17f21ef
to
b5790fe
Compare
b5790fe
to
b9fc9e6
Compare
rebased with latest main |
@lukaszstolarczuk Is it still failing ? |
it was failing in UR because of breaking change we introduced on main - the fix there is trivial. I just wanted to mention that UMF's compatibility is a general issue 😉 |
Merge changes from stable branch v0.10.x into main.
It includes also update of new symbols into our new versioning in symbols
.map
file.