[NativeCPU] Handle local args. #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvdijk
force-pushed
the
handle-local-args
branch
2 times, most recently
from
129289a to
7f53239
Compare
coldav
approved these changes
Jan 7, 2025
|
I think #2367 is a fuller version of this. |
uwedolinsky
reviewed
Jan 7, 2025
Agreed, if we can get that, we should. As discussed, since that will take a while to get reviewed, still going ahead with this as a short term solution. |
hvdijk
added
ready to merge
Depending on the number of available threads, NativeCPU goes through different code paths for launching kernels. Some of these were missing the call to kernel.handleLocalArgs, resulting in local pointers being left as nullptr. Skip this code path for kernels that use local pointers.
hvdijk
force-pushed
the
handle-local-args
branch
from
7f53239 to
6972fbb
Compare
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the number of available threads, NativeCPU goes through different code paths for launching kernels. Some of these were missing the call to
kernel.handleLocalArgs, resulting in local pointers being left asnullptr.intel/llvm#16500