Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search form #95

Merged
merged 4 commits into from
Apr 30, 2021
Merged

Search form #95

merged 4 commits into from
Apr 30, 2021

Conversation

dsbegnoche
Copy link
Contributor

Adding forms search parameter to filter forms by environment id, as discussed in #94

Copy link
Contributor

@mymattcarroll mymattcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

There are just a few things that will need to be addressed before we can approve and merge this Pull Request.

docs/forms-client.md Outdated Show resolved Hide resolved
docs/forms-client.md Outdated Show resolved Hide resolved
docs/forms-client.md Outdated Show resolved Hide resolved
OneBlink.SDK/FormsClient.cs Outdated Show resolved Hide resolved
OneBlink.SDK/FormsClient.cs Outdated Show resolved Hide resolved
OneBlink.SDK/FormsClient.cs Outdated Show resolved Hide resolved
OneBlink.SDK/FormsClient.cs Outdated Show resolved Hide resolved
@dsbegnoche
Copy link
Contributor Author

Thank you for the quick review. Updated PR with requested changes.

@mymattcarroll mymattcarroll merged commit 2e427cf into oneblink:master Apr 30, 2021
@mymattcarroll
Copy link
Contributor

@dsbegnoche Thank you for your contribution. We currently have unreleased features in master and cannot release them until the associated server work is done in the OneBlink product. We will publish a beta release soon with your changes, however, please be aware that a beta release cannot be considered stable and may not function exactly as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants