Skip to content

Unit tests #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Unit tests #9

wants to merge 4 commits into from

Conversation

martyu
Copy link

@martyu martyu commented Mar 25, 2025

No description provided.

Marty Ulrich added 4 commits March 24, 2025 10:51
Add Factory for injection.
Inject KeychainStorage
Some tests failing.
@@ -1,4 +1,4 @@
// swift-tools-version: 5.5
// swift-tools-version: 5.7
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recomend bumping this to 6.0 since it's a new project, and there was only one error I saw when changing it (Flow.Address needs to be Sendable)

@lmcmz
Copy link
Contributor

lmcmz commented Apr 1, 2025

Thanks @martyu for adding unit tests. Great work.
I will reuse some of the tests.
We don't default to keychain storage in purpose, since keychain has different attributes such as deviceOnly or syncToiCloud.
Different Key has different storage requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants