Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PersistentSlabStorage.GetAllChildReferences() for atree inlining #392

Conversation

fxamacker
Copy link
Member

This PR adds GetAllChildReferences() by wrapping an existing internal function added in PR #388 and adds about 1500 lines in tests.

NOTE: This is the same as approved/merged PR #391 which was done for the non-inlining branch.


  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

This commit adds GetAllChildReferences() which essentially wraps
an existing internal function.
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fxamacker fxamacker merged commit 300e7e8 into fxamacker/add-fix-broken-reference-function-for-atree-inlining Apr 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants