Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint to 1.56.2 #422

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

fxamacker
Copy link
Member

Bump golangci-lint to 1.56.2.
Bump go to 1.22.

This workflow is copied from fxamacker/cbor and these versions are also the same currently used by large open source projects.


  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Bump golangci-lint to 1.56.2.
Bump go to 1.22.

This workflow is copied from fxamacker/cbor and these versions are also the same currently used by large open source projects.
@fxamacker fxamacker added the CI CI and GitHub Actions Workflows label Jun 27, 2024
@fxamacker fxamacker self-assigned this Jun 27, 2024
@fxamacker
Copy link
Member Author

@ramtinms PTAL 🙏 Newer versions of golangci-lint are available but v1.56.2 works well and supports go1.22.

@fxamacker
Copy link
Member Author

fxamacker commented Jul 13, 2024

@turbolent updated reply with more info (hash vs version number).

@fxamacker fxamacker merged commit 0f5fef8 into main Jul 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI and GitHub Actions Workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants