Make smoke tests check if CBOR tag nums are reserved #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit checks if CBOR tag number is reserved by atree for internal use before smoke tests use it to encode Cadence values as elements in atree containers. As of Aug 15, 2024: - Atree reserves CBOR tag numbers [240, 255] for internal use. - Smoke tests reserves CBOR tag numbers [161, 239] for encoding elements in atree containers.
|
@ramtinms PTAL 🙏 the equivalent in Cadence repo for checking tags before use was approved by Bastian in |
|
@turbolent PTAL 🙏 |
No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks if CBOR tag number is reserved by atree for internal use before smoke tests use it to encode Cadence values as elements in atree containers.
As of Aug 15, 2024:
mainbranchFiles changedin the Github PR explorer