Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SlabID{...} with NewSlabID() in tests #479

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Replace SlabID{...} with NewSlabID() in tests #479

merged 1 commit into from
Jan 28, 2025

Conversation

fxamacker
Copy link
Member

Updates #464

This is necessary for upcoming refactor.

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker
Replace SlabID{...} with NewSlabID() in tests
96c8679 
This is necessary for upcoming refactor.
@fxamacker fxamacker self-assigned this Jan 23, 2025
@fxamacker fxamacker requested a review from turbolent as a code owner January 23, 2025 23:28
@fxamacker fxamacker changed the base branch from fxamacker/export-slab-id-length to main January 28, 2025 15:46
@fxamacker fxamacker merged commit cce9c14 into main Jan 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

Assignees

@fxamacker fxamacker

Labels
Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxamacker @turbolent