Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using unexported Array fields in tests #488

Conversation

fxamacker
Copy link
Member

Updates #464


  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker fxamacker self-assigned this Jan 27, 2025
@fxamacker fxamacker requested a review from turbolent as a code owner January 27, 2025 15:24
…rayDataSlab-directly-in-tests

Avoid creating ArrayDataSlab directly in tests
…map-fields-in-tests

Avoid using unexported `OrderedMap` fields in tests
@fxamacker fxamacker merged commit 1b0eed1 into fxamacker/avoid-using-unexported-consts-in-tests Jan 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants