Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LS] Fix wasm target #243

Merged
merged 1 commit into from
Nov 12, 2023
Merged

[LS] Fix wasm target #243

merged 1 commit into from
Nov 12, 2023

Conversation

bluesign
Copy link
Contributor

@bluesign bluesign commented Nov 11, 2023


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent
Copy link
Member

Thank you for fixing this! 🙏 Verified this is working as expected by running make build which builds both native and WASM binaries 👌

Could you please open this in two separate PRs, one against the test framework and another one against the LS?

I also opened #244 as a follow-up to prevent regressions like this

@bluesign
Copy link
Contributor Author

ah sure, I will separate it today.

@turbolent
Copy link
Member

https://github.com/onflow/cadence-tools/releases/tag/test%2Fv0.14.2 is released now.

@bluesign Could you please update the PR with just the LS changes, and replacing the go mod replace statement with an update to the latest cadence-tools/test release? Thank you!

@turbolent turbolent changed the title Fix Language Server wasm target [LS] Fix wasm target Nov 11, 2023
@bluesign bluesign marked this pull request as ready for review November 12, 2023 08:51
@bluesign
Copy link
Contributor Author

@turbolent should be ok now. Also changed PR status to ready for review.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks again 🙏

@turbolent turbolent merged commit 21fa4fb into onflow:master Nov 12, 2023
6 checks passed
@jribbink jribbink mentioned this pull request Apr 16, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants