[languageserver] Update to Cadence v1.0.0-preview.25 #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolent
commented
May 2, 2024
Comment on lines
+3
to
+5
| go 1.21 | ||
|
|
||
| toolchain go1.21.9 |
There was a problem hiding this comment.
Looks like flowkit is already on Go 1.21 now
SupunS
approved these changes
May 2, 2024
dsainati1
approved these changes
May 2, 2024
|
Guess because of the Go version bump to 1.21 we need to update |
|
No idea why the Go 1.21 breaks the WASM LS. From 1.20 to 1.21, something seems to have changed about timeouts. I tried a few things but no luck :/ |
|
All tests actually pass. What causes the CI failure is that after all tests have run, the test suite's shutdown function notifies the LS to exit, which calls Will merge and we'll need to address this in a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Automatically update to: