Remove workaround with compositeType.ResolveMembers()

onflow · Oct 12, 2023 · 1458dcf · 1458dcf
1 parent e69d6bb
commit 1458dcf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/runtime/sema/type.go b/runtime/sema/type.go
@@ -4294,11 +4294,7 @@ func (t *CompositeType) GetMembers() map[string]MemberResolver {
 }
 
 func (t *CompositeType) initializeMemberResolvers() {
-	t.memberResolversOnce.Do(t.initializerMemberResolversFunc())
-}
-
-func (t *CompositeType) initializerMemberResolversFunc() func() {
-	return func() {
+	t.memberResolversOnce.Do(func() {
 		memberResolvers := MembersMapAsResolvers(t.Members)
 
 		// Check conformances.
@@ -4317,13 +4313,7 @@ func (t *CompositeType) initializerMemberResolversFunc() func() {
 			})
 
 		t.memberResolvers = withBuiltinMembers(t, memberResolvers)
-	}
-}
-
-func (t *CompositeType) ResolveMembers() {
-	if t.Members.Len() != len(t.GetMembers()) {
-		t.initializerMemberResolversFunc()()
-	}
+	})
 }
 
 func (t *CompositeType) FieldPosition(name string, declaration ast.CompositeLikeDeclaration) ast.Position {

diff --git a/runtime/stdlib/test_contract.go b/runtime/stdlib/test_contract.go
@@ -1193,7 +1193,6 @@ func newTestContractType() *TestContractType {
 	ty.expectFailureFunction = newTestTypeExpectFailureFunction(
 		expectFailureFunctionType,
 	)
-	compositeType.ResolveMembers()
 
 	return ty
 }