Update to new Atree API #2620
Merged
Update to new Atree API #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates Cadence to use new Atree API - Array.Get() - OrderedMap.Get() - MaxInlineArrayElementSize() - MaxInlineMapKeySize() For more info, see Atree PRs: - onflow/atree#314 - onflow/atree#316 - onflow/atree#318
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 5f84e78 Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## feature/atree-register-inlining #2620 +/- ##
===================================================================
- Coverage 78.60% 78.60% -0.01%
===================================================================
Files 336 336
Lines 77869 77867 -2
===================================================================
- Hits 61207 61205 -2
Misses 14379 14379
Partials 2283 2283
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Given that this update will require a state migration, we should maybe have this and the other atree-related changes target a feature branch. |
@turbolent Good point! 👍 I organized into breaking changes vs non-breaking changes. By separating out non-breaking changes, I'm hoping to keep the feature branch simpler and easier to review. PRs with breaking changes:
PRs with non-breaking changes (continue to target master): Does this work for you? |
|
@fxamacker That works, thank you! |
turbolent
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates onflow/atree#292
Description
This PR updates Cadence to use new Atree API:
The new Atree API is part of prep work for Atree register inlining work.
For more info, see Atree PRs:
Array.Get()to returnValueinstead ofStorableatree#316OrderedMap.Get()to returnValueinstead ofStorableatree#318masterbranchFiles changedin the Github PR explorer