Conversion to entitled type #2693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:feature/stable-cadence commit 07f5125 Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
…to sainati/entitlement-sets
Codecov Report
@@ Coverage Diff @@
## feature/stable-cadence #2693 +/- ##
==========================================================
+ Coverage 79.39% 79.40% +0.01%
==========================================================
Files 336 336
Lines 80145 80176 +31
==========================================================
+ Hits 63628 63663 +35
+ Misses 14215 14211 -4
Partials 2302 2302
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Obseleted by #2951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the proposed migration in onflow/flips#95
Part of #2709
This implements and tests a function that converts types to entitled versions of themselves according to the rules described in the linked migration proposal. In particular:
ConvertToEntitledTypeconverts its input to an entitled type according to the following rules:ConvertToEntitledType(&T) ---> auth(Entitlements(T)) &TConvertToEntitledType(Capability<T>) ---> Capability<ConvertToEntitledType(T)>ConvertToEntitledType(T?) ---> ConvertToEntitledType(T)?ConvertToEntitledType(T) ---> Twhere
Entitlements(T)is defined as the result ofT.SupportedEntitlements()Note that these are the only types converted by this function; an existing composite type will not have its fields or function types migrated. This is because in the migration, composite values are not going to be migrated; they will simply possess the required entitlements already by virtue of being owned. This does mean, however, that existing composite values with capability-typed fields will break. This is unfortunately unavoidable, as capability-typed fields cannot have their types changed anyways according to the contract updatability rules.
masterbranchFiles changedin the Github PR explorer