-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test type order insignificance #2967
Test type order insignificance #2967
Conversation
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 866822a Collapsed results for better readability
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2967 +/- ##
==========================================
+ Coverage 80.00% 80.11% +0.11%
==========================================
Files 353 348 -5
Lines 82629 81870 -759
==========================================
- Hits 66106 65590 -516
+ Misses 14170 13958 -212
+ Partials 2353 2322 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@SupunS Could you please have a look here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I thought I already reviewed/approved this.
LGTM!
Work towards #2681
Description
Test that the order of types is insignificant, even across multiple transactions (encoding/decoding), for intersection types and authorizations (entitlements). In both cases the types are sets.
This was previously fixed in #2750 and #2749.
master
branchFiles changed
in the Github PR explorer